After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558576 - Add segmented bar to properties
Add segmented bar to properties
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: Removable Media
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-30 18:40 UTC by Bastien Nocera
Modified: 2018-05-24 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
media-sync-mac.jpg (64.98 KB, image/jpeg)
2008-10-30 18:44 UTC, Bastien Nocera
  Details
smsm-index_03.png (147.09 KB, image/png)
2008-10-30 18:45 UTC, Bastien Nocera
  Details
g1-linux-integration-crop.png (145.46 KB, image/png)
2008-10-30 18:46 UTC, Bastien Nocera
  Details
partitioner.png (239.46 KB, image/png)
2008-10-30 18:46 UTC, Bastien Nocera
  Details
Initial work (23.09 KB, patch)
2008-11-23 23:21 UTC, Christophe Fergeau
none Details | Review
Working widget (32.16 KB, patch)
2008-11-24 20:45 UTC, Christophe Fergeau
reviewed Details | Review
screenshot (5.38 KB, image/png)
2008-11-24 20:46 UTC, Christophe Fergeau
  Details
Add segmented bar to properties (31.27 KB, patch)
2010-01-14 11:00 UTC, Bastien Nocera
none Details | Review
Add segmented bar widget (31.97 KB, patch)
2010-01-14 11:16 UTC, Bastien Nocera
none Details | Review
Add segmented bar widget (31.98 KB, patch)
2010-01-14 11:17 UTC, Bastien Nocera
committed Details | Review
fix compilation (743 bytes, patch)
2010-02-02 16:56 UTC, Christophe Fergeau
committed Details | Review

Comment 1 Bastien Nocera 2008-10-30 18:44:53 UTC
Created attachment 121672 [details]
media-sync-mac.jpg
Comment 2 Bastien Nocera 2008-10-30 18:45:25 UTC
Created attachment 121673 [details]
smsm-index_03.png
Comment 3 Bastien Nocera 2008-10-30 18:46:05 UTC
Created attachment 121674 [details]
g1-linux-integration-crop.png
Comment 4 Bastien Nocera 2008-10-30 18:46:28 UTC
Created attachment 121675 [details]
partitioner.png
Comment 5 Christophe Fergeau 2008-11-23 23:21:52 UTC
Created attachment 123288 [details] [review]
Initial work

Some initial work for this bug, I ported the C# from Banshee to a C widget. So far it compiles but the widget displays nothing (I haven't had time to investigate yet). I haven't ported the text support yet, but it shouldn't be too hard, just a bit more code to write. I'm also planning to change the licence so something more liberal (LGPL, or maybe the same licence as banshee).
Comment 6 Christophe Fergeau 2008-11-24 20:45:53 UTC
Created attachment 123334 [details] [review]
Working widget

The widget can now display text, the API needs refining, some properties may be missing, but it's mostly working, the final tweaking and polishing can be done after experimenting with it.
Comment 7 Christophe Fergeau 2008-11-24 20:46:57 UTC
Created attachment 123335 [details]
screenshot

Forgot to mention that the size_allocate/size_request methods are probably buggy at the moment, I haven't investigated how those work. a11y should also be added.
Comment 8 Jonathan Matthew 2009-12-29 01:11:23 UTC
Review of attachment 123334 [details] [review]:

This generally looks good to me, and I'd like to make use of it in the media player source info dialog, instead of the normal progress bar we currently have there.

::: widgets/rb-segmented-bar.c
@@ +131,3 @@
+	priv->segment_box_spacing = 6;
+	priv->bar_height = 26; /* why is that necessary? the corresponding 
+				* property has a default value */

if you make it a construction property, the default value will be set during construction

@@ +492,3 @@
+
+static void hsb_from_color (Color *color, gdouble *hue,
+			    gdouble *saturation, gdouble *brightness)

this function doesn't exist somewhere in cairo or gdk or any other library we already use?

::: widgets/rb-segmented-bar.h
@@ +67,3 @@
+				   gdouble red, gdouble green,
+				   gdouble blue, gdouble alpha);
+void rb_segmented_bar_add_segment_default_color (RBSegmentedBar *bar,

maybe the add_segment functions should return the segment index to make it easier to update later?
Comment 9 Bastien Nocera 2010-01-14 11:00:52 UTC
Created attachment 151387 [details] [review]
Add segmented bar to properties

Port the segmented bar from Banshee.
Comment 10 Bastien Nocera 2010-01-14 11:16:01 UTC
Created attachment 151389 [details] [review]
Add segmented bar widget

Port the segmented bar from Banshee.
Comment 11 Bastien Nocera 2010-01-14 11:17:07 UTC
Created attachment 151390 [details] [review]
Add segmented bar widget

Port the segmented bar from Banshee.
Comment 12 Bastien Nocera 2010-01-14 11:19:35 UTC
This fixes all 3 comments from comment 8, and implements size_request with the minimum height set to the size of the bar +/- labels, and a minimum width of either 200, or the width of the labels (so they're not clipped).

Go to go?
Comment 13 Jonathan Matthew 2010-01-14 12:05:07 UTC
Review of attachment 151390 [details] [review]:

I think so.. now we just have to use it for something.
Comment 14 Bastien Nocera 2010-01-14 12:07:26 UTC
Comment on attachment 151390 [details] [review]
Add segmented bar widget

Attachment 151390 [details] pushed as 88e7e9c - Add segmented bar widget
Comment 15 Bastien Nocera 2010-01-14 12:12:20 UTC
Leaving opened so we can close this when it's used in media player properties.
Comment 16 Christophe Fergeau 2010-02-02 16:56:12 UTC
Created attachment 152854 [details] [review]
fix compilation

Rhythmbox master doesn't build for me without this patch.
Comment 17 Bastien Nocera 2010-02-02 17:08:49 UTC
Very possibly. Feel free to commit.
Comment 18 gnome.vrb 2016-10-22 06:13:49 UTC
Can this bug be closed ?
Comment 19 GNOME Infrastructure Team 2018-05-24 13:45:52 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/653.