GNOME Bugzilla – Bug 55833
pango uses locale-specific functions when it needs locale-independent operations
Last modified: 2004-12-22 21:47:04 UTC
Creating this bug to hold the patch for pango to use the non-locale-sensitive functions from bug 54166.
Created attachment 616 [details] [review] patch to use the new locale-independent glib calls and to fix one other locale problem
Besides using the locale-independent glib calls, this patch also fixes a place where pango used "%g" but always wanted a "." for a decimal separator.
Created attachment 617 [details] [review] improved patch that also gets rid of a storage leak
I should note that Owen told me the "change the locale and change back" approach used in this patch to fix the issue with %g is incorrect because the current locale is per-program rather than per-thread. The same problem exists today in Nautilus code. A partial fix may be to use the GNU extensions (__newlocale, et al.) where available.
We have g_ascii_strtod and g_ascii_dtostr now, so those can be used for the numeric formatting. (There is a instance of g_strtod in fonts.c that should be changed to g_ascii_strtod, since we don't want the "guessing" behavior of g_strtod)
Patch needs to be revisited because g_ascii_strdown now has a different interface than it did when I wrote the patch. There's also a PANGO_VERSOIN typo in the patch. In case it's helpful, I'll make a new version of the patch later today.
Updated and applied to cvs.