After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 55833 - pango uses locale-specific functions when it needs locale-independent operations
pango uses locale-specific functions when it needs locale-independent operations
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
0.x
Other Linux
: Normal normal
: 1.0.0
Assigned To: Owen Taylor
Owen Taylor
Depends on: 54166
Blocks:
 
 
Reported: 2001-06-06 17:38 UTC by Darin Adler
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to use the new locale-independent glib calls and to fix one other locale problem (16.57 KB, patch)
2001-06-06 17:39 UTC, Darin Adler
none Details | Review
improved patch that also gets rid of a storage leak (17.18 KB, patch)
2001-06-06 17:43 UTC, Darin Adler
none Details | Review

Description Darin Adler 2001-06-06 17:38:54 UTC
Creating this bug to hold the patch for pango to use the
non-locale-sensitive functions from bug 54166.
Comment 1 Darin Adler 2001-06-06 17:39:52 UTC
Created attachment 616 [details] [review]
patch to use the new locale-independent glib calls and to fix one other locale problem
Comment 2 Darin Adler 2001-06-06 17:40:30 UTC
Besides using the locale-independent glib calls, this patch also fixes
a place where pango used "%g" but always wanted a "." for a decimal
separator.
Comment 3 Darin Adler 2001-06-06 17:43:51 UTC
Created attachment 617 [details] [review]
improved patch that also gets rid of a storage leak
Comment 4 Darin Adler 2001-06-06 23:20:05 UTC
I should note that Owen told me the "change the locale and change
back" approach used in this patch to fix the issue with %g is
incorrect because the current locale is per-program rather than
per-thread. The same problem exists today in Nautilus code. A partial
fix may be to use the GNU extensions (__newlocale, et al.) where
available.
Comment 5 Owen Taylor 2001-10-25 15:11:01 UTC
We have g_ascii_strtod and g_ascii_dtostr now, so those
can be used for the numeric formatting.

(There is a instance of g_strtod in fonts.c that should be changed
to g_ascii_strtod, since we don't want the "guessing"
behavior of g_strtod)
Comment 6 Darin Adler 2001-10-25 15:24:42 UTC
Patch needs to be revisited because g_ascii_strdown now has a
different interface than it did when I wrote the patch.

There's also a PANGO_VERSOIN typo in the patch.

In case it's helpful, I'll make a new version of the patch later
today.
Comment 7 Owen Taylor 2001-11-02 14:24:55 UTC
Updated and applied to cvs.