Bug 558309 - Unquoted variable names
Unquoted variable names
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2008-10-28 23:18 UTC by Leonardo Ferreira Fontenelle
Modified: 2008-10-29 23:39 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Leonardo Ferreira Fontenelle 2008-10-28 23:18:07 UTC 
#: ../src/ui/theme-parser.c:1343 ../src/ui/theme-parser.c:1357
#: ../src/ui/theme-parser.c:1402
msgid ""
"Cannot specify both button_width/button_height and aspect ratio for buttons"

If "button_width" and "button_height" are not to be translated, they must be quoted; same for aspect ratio. Is this a message for the end user, or is it a debug message? If it's a debug message, maybe it should not be translated, should it?
Comment 1 Thomas Thurman 2008-10-28 23:20:20 UTC 
It's a message for theme developers; do they count as end users?
Comment 2 Leonardo Ferreira Fontenelle 2008-10-28 23:44:59 UTC 
Oh, then I _believe_ they would prefer the message to be translated.

But I'm still sure button_height shouldn't be translated to altura_do_botão :D So it would be better to enclose the names in double quotes:

http://live.gnome.org/TranslationProject/DevGuidelines/Enclose%20literal%20values%20in%20double%20quotes
Comment 3 Thomas Thurman 2008-10-29 23:39:40 UTC 
Good point.  Fixed.  Thanks.
Note You need to log in before you can comment on or make changes to this bug.