After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558120 - Downloaded files are read-only
Downloaded files are read-only
Status: RESOLVED NOTABUG
Product: banshee
Classification: Other
Component: Podcasting
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Mike Urbanski
Mike Urbanski
Depends on:
Blocks:
 
 
Reported: 2008-10-27 16:08 UTC by Ivan Zlatev
Modified: 2008-12-12 17:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Test podcast deletion fail (693 bytes, patch)
2008-12-12 17:16 UTC, Benjamín Valero Espinosa 		none Details | Review

Description Ivan Zlatev 2008-10-27 16:08:46 UTC 
Please describe the problem:
Downloaded files have read-only permissions set. This seems wrong.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Mike Urbanski 2008-10-27 16:36:33 UTC 
This is by design.

When downloaded, podcast files are marked read-only.  When an item's parent feed is deleted, its enclosure directory is also deleted if no RW files are present.  If a deleted feed's enclosure directory contains both RO and RW files, the RO files are deleted while RW files are left untouched.

So, if you modify a downloaded file, it will not be removed automatically when deleting the parent feed.

I'm not sure if this has changed since release.
Comment 2 Benjamín Valero Espinosa 2008-12-12 17:13:27 UTC 
Well, it seems that not that way. I have tried to unsuscribe from a feed, so the podcasts downloaded should be deleted. Before I have checked that the files have read-only permissions (-r--r--r--).

I have unsuscribed, the feed has been removed from the GUI and also all the items, but the downloaded file is still there. I have changed a little the code to show the Exception (I also attach this change), and when I do the same, I get that:

EXCEPTION: System.UnauthorizedAccessException: Access to the path "/home/benja/XXXX/xxx.mp3" is denied.

Curious, if I change the permissiones to the file so is RW, then I do the same and all works as expected.

So, I don't find any reason to keep the RO permissions for downloaded podcast. I hope I have explained, my English is very bad.
Comment 3 Benjamín Valero Espinosa 2008-12-12 17:16:35 UTC 
Created attachment 124539 [details] [review]
Test podcast deletion fail