GNOME Bugzilla – Bug 558058
Metacity crashing with new GDM 2.24.
Last modified: 2008-10-27 15:17:22 UTC
On Solaris, I am seeing metacity crash when switching from the GDM session to the user session. The attached patch fixes these problems. It seems to be some issues with strcmp not handling NULL arguments properly. Can this patch go upstream?
Created attachment 121415 [details] [review] patch fixing crash issue
Committed: http://svn.gnome.org/viewvc/metacity?rev=4003&view=rev The fixes to ui.c were effectively already done in r4001 (http://svn.gnome.org/viewvc/metacity?rev=4003&view=rev) but I think an extra null check never hurt anyone. I've also gone through and added checks in all the similar code paths in the other string handlers. What changed in GDM to expose this, btw? It ought only to happen when a key is expected but doesn't exist.
er, r4001 is http://svn.gnome.org/viewvc/metacity?rev=4001&view=rev of course.
To be honest, I think what exposed this is that I had my "gdm" user's .gconf settings not set up properly. Still, I thought it would be good to get these fixes upstream so that metacity doesn't crash when GConf isn't set up properly. Thanks.