After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557662 - Cannot build doc without exif enabled.
Cannot build doc without exif enabled.
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
: 567770 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-23 20:59 UTC by Gilles Dartiguelongue
Modified: 2009-01-19 12:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Patch to build EXIF documentation conditionally (8.43 KB, patch)
2009-01-18 12:30 UTC, Arun Raghavan
needs-work Details | Review
Updated patch to disable documentation based on exif/exempi selection (9.55 KB, patch)
2009-01-18 18:38 UTC, Arun Raghavan
committed Details | Review

Description Gilles Dartiguelongue 2008-10-23 20:59:58 UTC
Here is out downstream report,

https://bugs.gentoo.org/show_bug.cgi?id=242868

I figured out this is because of the statusbar-date plugin. Afaics, plugins don't have docs so I just stripped the plugins folder from the INCLUDES in doc/references/Makefile.am, autoreconf and done.

Thanks for considering.
Comment 1 Felix Riemann 2008-11-03 18:00:28 UTC
Hmm, yeah. The problem is that docs generation is not really "dynamic" as it should be. If you compile without exif and xmp support the EogExifDetails class won't be compiled, but the docs parser still expects it to be available.

Your fix is not working (here at least) because it just modifies the parsers include path which has no effect on linking.
The probable workaround for Gentoo (or other distros where libexif and xmp can be disabled) would be to remove the eog_exif_details_get_type line from doc/reference/eog.types if USE="-exif -xmp doc":

sed '/^eog_exif_details_get_type$/d' -i doc/reference/eog.types

This fixes the compilation error at least and works even without autoreconf.
The real fix is probably to integrate eog.types into the autotools run if there is no facility from gtk-doc for this.
Comment 2 Gilles Dartiguelongue 2008-11-04 07:48:09 UTC
actually, eog.types is autogenerated by gtk-doc (iirc) so the proper fix is to make sure the code doesn't use exif related stuff without the proper ifdefs. The solution I described above is clearly ugly because it's too extensive. It's just a quick hack.
Comment 3 Felix Riemann 2009-01-14 21:37:56 UTC
*** Bug 567770 has been marked as a duplicate of this bug. ***
Comment 4 Arun Raghavan 2009-01-18 12:30:34 UTC
Created attachment 126684 [details] [review]
Patch to build EXIF documentation conditionally

This patch regenerates eog.types and conditionally comments out exif stuff in eog-docs.sgml if EXIF support is not present.
Comment 5 Felix Riemann 2009-01-18 13:18:42 UTC
(In reply to comment #4)
> Created an attachment (id=126684) [edit]
> Patch to build EXIF documentation conditionally
> 
> This patch regenerates eog.types and conditionally comments out exif stuff in
> eog-docs.sgml if EXIF support is not present.
> 
Looks good so far. You need to change the configure part though. This problem only occurs if you build without both libexif and exempi. Once one of these is included EogExifDetails is built and gtk-doc won't fail compiling (there is a bug about renaming it around).
Comment 6 Arun Raghavan 2009-01-18 18:38:52 UTC
Created attachment 126702 [details] [review]
Updated patch to disable documentation based on exif/exempi selection

Here's an updated patch that only disables the documentation only if both libexif and exempi are disabled.
Comment 7 Felix Riemann 2009-01-19 11:36:14 UTC
Thanks. Committed with a slight modification to the Makefile:

2009-01-19  Felix Riemann  <>

	* configure.ac:
	* doc/reference/Makefile.am:
	* doc/reference/eog-docs.sgml:
	* doc/reference/eog-docs.sgml.in:
	* doc/reference/eog.types:
	Fix gtk-doc compilation when not compiling with any of libexif or
	exempi. Fixes bug#557662 (Arun Raghavan).

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 8 Arun Raghavan 2009-01-19 12:08:03 UTC
Thanks for committing.

Shouldn't EXTRA_DIST in docs/reference/Makefile.am have $(DOC_MODULE)-docs.sgml.in instead of $(DOC_MODULE)-docs.sgml?
Comment 9 Felix Riemann 2009-01-19 12:20:46 UTC
Oops, right. Fixed it. Thanks.