GNOME Bugzilla – Bug 557662
Cannot build doc without exif enabled.
Last modified: 2009-01-19 12:20:46 UTC
Here is out downstream report, https://bugs.gentoo.org/show_bug.cgi?id=242868 I figured out this is because of the statusbar-date plugin. Afaics, plugins don't have docs so I just stripped the plugins folder from the INCLUDES in doc/references/Makefile.am, autoreconf and done. Thanks for considering.
Hmm, yeah. The problem is that docs generation is not really "dynamic" as it should be. If you compile without exif and xmp support the EogExifDetails class won't be compiled, but the docs parser still expects it to be available. Your fix is not working (here at least) because it just modifies the parsers include path which has no effect on linking. The probable workaround for Gentoo (or other distros where libexif and xmp can be disabled) would be to remove the eog_exif_details_get_type line from doc/reference/eog.types if USE="-exif -xmp doc": sed '/^eog_exif_details_get_type$/d' -i doc/reference/eog.types This fixes the compilation error at least and works even without autoreconf. The real fix is probably to integrate eog.types into the autotools run if there is no facility from gtk-doc for this.
actually, eog.types is autogenerated by gtk-doc (iirc) so the proper fix is to make sure the code doesn't use exif related stuff without the proper ifdefs. The solution I described above is clearly ugly because it's too extensive. It's just a quick hack.
*** Bug 567770 has been marked as a duplicate of this bug. ***
Created attachment 126684 [details] [review] Patch to build EXIF documentation conditionally This patch regenerates eog.types and conditionally comments out exif stuff in eog-docs.sgml if EXIF support is not present.
(In reply to comment #4) > Created an attachment (id=126684) [edit] > Patch to build EXIF documentation conditionally > > This patch regenerates eog.types and conditionally comments out exif stuff in > eog-docs.sgml if EXIF support is not present. > Looks good so far. You need to change the configure part though. This problem only occurs if you build without both libexif and exempi. Once one of these is included EogExifDetails is built and gtk-doc won't fail compiling (there is a bug about renaming it around).
Created attachment 126702 [details] [review] Updated patch to disable documentation based on exif/exempi selection Here's an updated patch that only disables the documentation only if both libexif and exempi are disabled.
Thanks. Committed with a slight modification to the Makefile: 2009-01-19 Felix Riemann <> * configure.ac: * doc/reference/Makefile.am: * doc/reference/eog-docs.sgml: * doc/reference/eog-docs.sgml.in: * doc/reference/eog.types: Fix gtk-doc compilation when not compiling with any of libexif or exempi. Fixes bug#557662 (Arun Raghavan). This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Thanks for committing. Shouldn't EXTRA_DIST in docs/reference/Makefile.am have $(DOC_MODULE)-docs.sgml.in instead of $(DOC_MODULE)-docs.sgml?
Oops, right. Fixed it. Thanks.