GNOME Bugzilla – Bug 557344
Add support for Audioscrobbler Love/Ban actions on non-radio source.
Last modified: 2008-12-15 02:49:34 UTC
Last.fm's Love/Ban actions are currently available when playing a radio stream from Last.fm. This patch adds support for Love/Ban actions to Banshee when playing any song with artist and track tags. When a song is loaded (playing or paused), if an user is connected to Last.fm, you should now see smileys on the top-right part of the client. Otherwise, they disappear. Here is the ChangeLog: 2008-10-21 Warren Seine <warren.seine@gmail.com> Add support for Audioscrobbler Love/Ban actions on non-radio source. * src/Extensions/Banshee.Lastfm/Banshee.Lastfm.Audioscrobbler/ AudioscrobblerActions.cs: New. Separate GUI from service. * src/Extensions/Banshee.Lastfm/Banshee.Lastfm.Audioscrobbler/AudioscrobblerService.cs: * src/Extensions/Banshee.Lastfm/Banshee.Lastfm.Radio/LastfmActions.cs: Move Love/Ban actions to Banshee.Lastfm.Audioscrobbler instead of Banshee.Lastfm.Radio. Radio and scrobbling work separately. * src/Extensions/Banshee.Lastfm/Banshee.Lastfm.csproj: * src/Extensions/Banshee.Lastfm/Makefile.am: Updated with new file. * src/Extensions/Banshee.Lastfm/Resources/GlobalUI.xml: * src/Extensions/Banshee.Lastfm/Resources/LastfmTrackActions.xml: Update GUI to show the Love/Ban smiley/buttons even if the current source is local (appears if connected to Last.fm and having a song loaded). Still a small problem in the NotificationArea: the Love/Ban entries do not appear in their placeholder. Looks like a bug cause by the Audioscrobbler plugin being loaded before the NotificationArea plugin. * src/Libraries/Lastfm/Lastfm/AudioscrobblerConnection.cs: Change enum State to AudioscrobblerState (for coherence with RadioConnection.cs). Add handler on Audioscrobbler state change.
Created attachment 121080 [details] [review] Add support for Audioscrobbler Love/Ban actions on non-radio source.
Any review?
Bug #527373 is about the same enhancement, and already has some discussion. Would you mind attaching your patch there and mark this as a duplicate ? Sorry for not noticing this earlier.
*** This bug has been marked as a duplicate of 527373 ***