GNOME Bugzilla – Bug 557308
TypeError: unsupported operand type(s) for +=: 'NoneType' and 'float'
Last modified: 2008-11-24 13:35:09 UTC
Version: 2.24.1 What were you doing when the application crashed? Just playing the program on medium, in the background firefox is running playing music on Pandora. Openoffice has a document open. No other program crashed or had any problems. Distribution: Ubuntu 8.10 (intrepid) Gnome Release: 2.24.0 2008-10-07 (Ubuntu) BugBuddy Version: 2.24.1 System: Linux 2.6.27-7-generic #1 SMP Fri Oct 17 22:24:21 UTC 2008 i686 X Vendor: The X.Org Foundation X Vendor Release: 10502000 Selinux: No Accessibility: Disabled GTK+ Theme: Clearlooks Icon Theme: gnome Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0 CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0 ----------- .xsession-errors --------------------- TypeError: unsupported operand type(s) for +=: 'NoneType' and 'float' Traceback (most recent call last):
+ Trace 208504
self.sudoku_tracker.save_game(self)
jar = jar_game(ui)
ui.timer.finish_timing()
self.toggle_timing(False)
self.tot_time_complete += end_time - self.__absolute_start_time__
-------------------------------------------------- Traceback (most recent call last):
*** Bug 557355 has been marked as a duplicate of this bug. ***
*** Bug 557440 has been marked as a duplicate of this bug. ***
*** Bug 557533 has been marked as a duplicate of this bug. ***
*** Bug 557823 has been marked as a duplicate of this bug. ***
*** Bug 558004 has been marked as a duplicate of this bug. ***
*** Bug 558034 has been marked as a duplicate of this bug. ***
*** Bug 558172 has been marked as a duplicate of this bug. ***
*** Bug 558174 has been marked as a duplicate of this bug. ***
*** Bug 558223 has been marked as a duplicate of this bug. ***
*** Bug 558251 has been marked as a duplicate of this bug. ***
*** Bug 558280 has been marked as a duplicate of this bug. ***
*** Bug 558297 has been marked as a duplicate of this bug. ***
*** Bug 558299 has been marked as a duplicate of this bug. ***
*** Bug 557811 has been marked as a duplicate of this bug. ***
*** Bug 557821 has been marked as a duplicate of this bug. ***
*** Bug 557966 has been marked as a duplicate of this bug. ***
*** Bug 557993 has been marked as a duplicate of this bug. ***
*** Bug 558035 has been marked as a duplicate of this bug. ***
*** Bug 558173 has been marked as a duplicate of this bug. ***
*** Bug 558328 has been marked as a duplicate of this bug. ***
So this is something left by Bug #556155. Do we add something to check for the old saved games (if possible), or do we just let it go and (hopefully someday) nobody comes upon those old saved games?
The old game-saving file lacks something like the following entry: sS'timer.tot_time_complete' p14 F750021.91351509094 s. This results "ui.timer.tot_time_complete" to be over-written as "None" somewhere:
+ Trace 208915
start_game()
super_setattr(ui,attr,jar.get(attr,None))
The above happens because, after reading the saved file, nothing is filled in "tot_time_complete", so in the above "open_game", "jar.get(attr,None)" will return None, which is assigned to "tot_time_complete" (in function super_setattr). I have a simple fix, which is of course not perfect... Please tell me if it is not proper :)
Created attachment 121644 [details] [review] fix the saved-time problem and also dancer problem I simply loop through SAVE_ATTRIBUTES and check to see if there is None value. If so, change it to 0. This zero value may be not proper. The patch to main.py results here: http://bugzilla.gnome.org/show_bug.cgi?id=532357#c28 I think it's easy enough to be included :)
Hi Zhang. I suck. I only thought the time would be wrong for old 2.24.0 games. Not that the game would crash. I had a quick glance at the patch and it looks good to me. Both the save game fix and the dancer fix. I'll test them properly later. I have pretty much dropped the ball on gnome-sudoku while doing the libgnome stuff. It's great that you are looking at the bugs Zhang. Keep up the good work!
The patches worked fine. (as always with patches from you Zhang) I've committed the fix to branch and trunk. Will be in 2.24.2 and 2.25.1. (I committed the patch for the other bug separately to keep the log cleaner.) Thanks so much! http://svn.gnome.org/viewvc/gnome-games?view=revision&revision=8220 http://svn.gnome.org/viewvc/gnome-games?view=revision&revision=8223
*** Bug 558542 has been marked as a duplicate of this bug. ***
*** Bug 558579 has been marked as a duplicate of this bug. ***
*** Bug 558580 has been marked as a duplicate of this bug. ***
*** Bug 558585 has been marked as a duplicate of this bug. ***
*** Bug 558588 has been marked as a duplicate of this bug. ***
*** Bug 558616 has been marked as a duplicate of this bug. ***
*** Bug 558618 has been marked as a duplicate of this bug. ***
*** Bug 558664 has been marked as a duplicate of this bug. ***
*** Bug 558685 has been marked as a duplicate of this bug. ***
*** Bug 558692 has been marked as a duplicate of this bug. ***
*** Bug 558702 has been marked as a duplicate of this bug. ***
*** Bug 558704 has been marked as a duplicate of this bug. ***
*** Bug 558766 has been marked as a duplicate of this bug. ***
*** Bug 558768 has been marked as a duplicate of this bug. ***
*** Bug 558783 has been marked as a duplicate of this bug. ***
*** Bug 558784 has been marked as a duplicate of this bug. ***
*** Bug 558575 has been marked as a duplicate of this bug. ***
*** Bug 558578 has been marked as a duplicate of this bug. ***
*** Bug 558625 has been marked as a duplicate of this bug. ***
*** Bug 558652 has been marked as a duplicate of this bug. ***
*** Bug 558675 has been marked as a duplicate of this bug. ***
*** Bug 558687 has been marked as a duplicate of this bug. ***
*** Bug 558701 has been marked as a duplicate of this bug. ***
*** Bug 558725 has been marked as a duplicate of this bug. ***
*** Bug 558732 has been marked as a duplicate of this bug. ***
*** Bug 558742 has been marked as a duplicate of this bug. ***
*** Bug 558748 has been marked as a duplicate of this bug. ***
*** Bug 558754 has been marked as a duplicate of this bug. ***
*** Bug 558762 has been marked as a duplicate of this bug. ***
*** Bug 558765 has been marked as a duplicate of this bug. ***
*** Bug 558767 has been marked as a duplicate of this bug. ***
*** Bug 558764 has been marked as a duplicate of this bug. ***
*** Bug 558789 has been marked as a duplicate of this bug. ***
*** Bug 558774 has been marked as a duplicate of this bug. ***
*** Bug 558793 has been marked as a duplicate of this bug. ***
*** Bug 558825 has been marked as a duplicate of this bug. ***
*** Bug 558845 has been marked as a duplicate of this bug. ***
*** Bug 558816 has been marked as a duplicate of this bug. ***
*** Bug 558820 has been marked as a duplicate of this bug. ***
*** Bug 558829 has been marked as a duplicate of this bug. ***
*** Bug 558831 has been marked as a duplicate of this bug. ***
*** Bug 558837 has been marked as a duplicate of this bug. ***
*** Bug 558842 has been marked as a duplicate of this bug. ***
*** Bug 558874 has been marked as a duplicate of this bug. ***
*** Bug 558872 has been marked as a duplicate of this bug. ***
*** Bug 558869 has been marked as a duplicate of this bug. ***
*** Bug 558866 has been marked as a duplicate of this bug. ***
*** Bug 558863 has been marked as a duplicate of this bug. ***
*** Bug 558859 has been marked as a duplicate of this bug. ***
*** Bug 558857 has been marked as a duplicate of this bug. ***
*** Bug 558854 has been marked as a duplicate of this bug. ***
*** Bug 558853 has been marked as a duplicate of this bug. ***
*** Bug 558876 has been marked as a duplicate of this bug. ***
*** Bug 558893 has been marked as a duplicate of this bug. ***
*** Bug 558884 has been marked as a duplicate of this bug. ***
*** Bug 558924 has been marked as a duplicate of this bug. ***
*** Bug 558923 has been marked as a duplicate of this bug. ***
*** Bug 558920 has been marked as a duplicate of this bug. ***
*** Bug 558918 has been marked as a duplicate of this bug. ***
*** Bug 558917 has been marked as a duplicate of this bug. ***
*** Bug 558915 has been marked as a duplicate of this bug. ***
*** Bug 558946 has been marked as a duplicate of this bug. ***
*** Bug 558966 has been marked as a duplicate of this bug. ***
*** Bug 558965 has been marked as a duplicate of this bug. ***
*** Bug 558974 has been marked as a duplicate of this bug. ***
*** Bug 558981 has been marked as a duplicate of this bug. ***
*** Bug 558992 has been marked as a duplicate of this bug. ***
*** Bug 558991 has been marked as a duplicate of this bug. ***
*** Bug 559030 has been marked as a duplicate of this bug. ***
*** Bug 559007 has been marked as a duplicate of this bug. ***
*** Bug 558999 has been marked as a duplicate of this bug. ***
*** Bug 558995 has been marked as a duplicate of this bug. ***
*** Bug 559083 has been marked as a duplicate of this bug. ***
*** Bug 559108 has been marked as a duplicate of this bug. ***
*** Bug 559072 has been marked as a duplicate of this bug. ***
*** Bug 559221 has been marked as a duplicate of this bug. ***
*** Bug 559211 has been marked as a duplicate of this bug. ***
*** Bug 559191 has been marked as a duplicate of this bug. ***
*** Bug 559175 has been marked as a duplicate of this bug. ***
*** Bug 559275 has been marked as a duplicate of this bug. ***
*** Bug 559307 has been marked as a duplicate of this bug. ***
*** Bug 559316 has been marked as a duplicate of this bug. ***
*** Bug 559328 has been marked as a duplicate of this bug. ***
*** Bug 559329 has been marked as a duplicate of this bug. ***
*** Bug 559294 has been marked as a duplicate of this bug. ***
*** Bug 559283 has been marked as a duplicate of this bug. ***
*** Bug 559321 has been marked as a duplicate of this bug. ***
*** Bug 559322 has been marked as a duplicate of this bug. ***
*** Bug 559358 has been marked as a duplicate of this bug. ***
*** Bug 559357 has been marked as a duplicate of this bug. ***
*** Bug 559356 has been marked as a duplicate of this bug. ***
*** Bug 559355 has been marked as a duplicate of this bug. ***
*** Bug 559339 has been marked as a duplicate of this bug. ***
*** Bug 559375 has been marked as a duplicate of this bug. ***
*** Bug 559373 has been marked as a duplicate of this bug. ***
*** Bug 559369 has been marked as a duplicate of this bug. ***
*** Bug 559377 has been marked as a duplicate of this bug. ***
*** Bug 559381 has been marked as a duplicate of this bug. ***
*** Bug 559398 has been marked as a duplicate of this bug. ***
*** Bug 559397 has been marked as a duplicate of this bug. ***
*** Bug 559412 has been marked as a duplicate of this bug. ***
*** Bug 559435 has been marked as a duplicate of this bug. ***
*** Bug 559440 has been marked as a duplicate of this bug. ***
*** Bug 559445 has been marked as a duplicate of this bug. ***
*** Bug 559442 has been marked as a duplicate of this bug. ***
*** Bug 559536 has been marked as a duplicate of this bug. ***
*** Bug 559523 has been marked as a duplicate of this bug. ***
*** Bug 559507 has been marked as a duplicate of this bug. ***
*** Bug 559492 has been marked as a duplicate of this bug. ***
*** Bug 559554 has been marked as a duplicate of this bug. ***
*** Bug 559553 has been marked as a duplicate of this bug. ***
*** Bug 559552 has been marked as a duplicate of this bug. ***
*** Bug 559546 has been marked as a duplicate of this bug. ***
*** Bug 559674 has been marked as a duplicate of this bug. ***
*** Bug 559660 has been marked as a duplicate of this bug. ***
*** Bug 559658 has been marked as a duplicate of this bug. ***
*** Bug 559655 has been marked as a duplicate of this bug. ***
*** Bug 559602 has been marked as a duplicate of this bug. ***
*** Bug 559600 has been marked as a duplicate of this bug. ***
*** Bug 559597 has been marked as a duplicate of this bug. ***
*** Bug 559596 has been marked as a duplicate of this bug. ***
*** Bug 559677 has been marked as a duplicate of this bug. ***
*** Bug 559679 has been marked as a duplicate of this bug. ***
*** Bug 559680 has been marked as a duplicate of this bug. ***
*** Bug 559754 has been marked as a duplicate of this bug. ***
*** Bug 559745 has been marked as a duplicate of this bug. ***
*** Bug 559743 has been marked as a duplicate of this bug. ***
*** Bug 559742 has been marked as a duplicate of this bug. ***
*** Bug 559758 has been marked as a duplicate of this bug. ***
*** Bug 559767 has been marked as a duplicate of this bug. ***
*** Bug 559780 has been marked as a duplicate of this bug. ***
*** Bug 559791 has been marked as a duplicate of this bug. ***
*** Bug 559792 has been marked as a duplicate of this bug. ***
*** Bug 559802 has been marked as a duplicate of this bug. ***
*** Bug 559831 has been marked as a duplicate of this bug. ***
*** Bug 559842 has been marked as a duplicate of this bug. ***
*** Bug 559843 has been marked as a duplicate of this bug. ***
*** Bug 559845 has been marked as a duplicate of this bug. ***
*** Bug 559846 has been marked as a duplicate of this bug. ***
*** Bug 559847 has been marked as a duplicate of this bug. ***
*** Bug 559850 has been marked as a duplicate of this bug. ***
*** Bug 559851 has been marked as a duplicate of this bug. ***
*** Bug 559854 has been marked as a duplicate of this bug. ***
*** Bug 559857 has been marked as a duplicate of this bug. ***
*** Bug 559858 has been marked as a duplicate of this bug. ***
*** Bug 559859 has been marked as a duplicate of this bug. ***
*** Bug 559864 has been marked as a duplicate of this bug. ***
*** Bug 559866 has been marked as a duplicate of this bug. ***
*** Bug 559871 has been marked as a duplicate of this bug. ***
*** Bug 559930 has been marked as a duplicate of this bug. ***
*** Bug 559948 has been marked as a duplicate of this bug. ***
*** Bug 559943 has been marked as a duplicate of this bug. ***
*** Bug 559942 has been marked as a duplicate of this bug. ***
*** Bug 559936 has been marked as a duplicate of this bug. ***
*** Bug 559944 has been marked as a duplicate of this bug. ***
*** Bug 559934 has been marked as a duplicate of this bug. ***
*** Bug 559931 has been marked as a duplicate of this bug. ***
*** Bug 559910 has been marked as a duplicate of this bug. ***
*** Bug 559916 has been marked as a duplicate of this bug. ***
*** Bug 559912 has been marked as a duplicate of this bug. ***
*** Bug 559906 has been marked as a duplicate of this bug. ***
*** Bug 559901 has been marked as a duplicate of this bug. ***
*** Bug 559897 has been marked as a duplicate of this bug. ***
*** Bug 559888 has been marked as a duplicate of this bug. ***
*** Bug 559886 has been marked as a duplicate of this bug. ***
*** Bug 559898 has been marked as a duplicate of this bug. ***
*** Bug 559894 has been marked as a duplicate of this bug. ***
*** Bug 559967 has been marked as a duplicate of this bug. ***
*** Bug 559957 has been marked as a duplicate of this bug. ***
*** Bug 560059 has been marked as a duplicate of this bug. ***
*** Bug 560056 has been marked as a duplicate of this bug. ***
*** Bug 560044 has been marked as a duplicate of this bug. ***
*** Bug 560030 has been marked as a duplicate of this bug. ***
*** Bug 560028 has been marked as a duplicate of this bug. ***
*** Bug 560027 has been marked as a duplicate of this bug. ***
*** Bug 560003 has been marked as a duplicate of this bug. ***
*** Bug 560002 has been marked as a duplicate of this bug. ***
*** Bug 559998 has been marked as a duplicate of this bug. ***
*** Bug 560000 has been marked as a duplicate of this bug. ***
*** Bug 560095 has been marked as a duplicate of this bug. ***
*** Bug 560072 has been marked as a duplicate of this bug. ***
*** Bug 560126 has been marked as a duplicate of this bug. ***
*** Bug 560140 has been marked as a duplicate of this bug. ***
*** Bug 560160 has been marked as a duplicate of this bug. ***
*** Bug 560141 has been marked as a duplicate of this bug. ***
*** Bug 560197 has been marked as a duplicate of this bug. ***
*** Bug 560191 has been marked as a duplicate of this bug. ***
*** Bug 560269 has been marked as a duplicate of this bug. ***
*** Bug 560257 has been marked as a duplicate of this bug. ***
*** Bug 560256 has been marked as a duplicate of this bug. ***
*** Bug 560255 has been marked as a duplicate of this bug. ***
*** Bug 560240 has been marked as a duplicate of this bug. ***
*** Bug 560239 has been marked as a duplicate of this bug. ***
*** Bug 560214 has been marked as a duplicate of this bug. ***
*** Bug 560205 has been marked as a duplicate of this bug. ***
*** Bug 560312 has been marked as a duplicate of this bug. ***
*** Bug 560292 has been marked as a duplicate of this bug. ***
*** Bug 560273 has been marked as a duplicate of this bug. ***
There are different types of stacktraces marked as duplicates of this bug. From a quick view I've found three different traces, while the trace in comment 0 was the most "popular" trace. I've added that one to the auto-rejecter, telling people to update to 2.24.2 when it's out on Nov 26th. There still we be duplicates (the other two types of stacktraces that are shorter than the "main" one I've auto-rejected).
I released 2.24.1.1 with the fix for this bug in it. For ubuntu it has been in -proposed for a few days. I think their policy is for updates to wait there one whole week before they are released on everyone. Any reports on whether 2.24.1.1 fixes all these issues would be very much appreciated!
phomes: Ah, OK. A notice here would have been nice. Well, next time. :-) /me correcting the email we send from the auto-rejecter.
*** Bug 560370 has been marked as a duplicate of this bug. ***
*** Bug 560386 has been marked as a duplicate of this bug. ***
*** Bug 560333 has been marked as a duplicate of this bug. ***
*** Bug 560433 has been marked as a duplicate of this bug. ***
*** Bug 560470 has been marked as a duplicate of this bug. ***
*** Bug 560619 has been marked as a duplicate of this bug. ***
*** Bug 560694 has been marked as a duplicate of this bug. ***
*** Bug 560700 has been marked as a duplicate of this bug. ***
*** Bug 560710 has been marked as a duplicate of this bug. ***
*** Bug 560842 has been marked as a duplicate of this bug. ***
*** Bug 560854 has been marked as a duplicate of this bug. ***
*** Bug 560901 has been marked as a duplicate of this bug. ***
*** Bug 560905 has been marked as a duplicate of this bug. ***
*** Bug 561025 has been marked as a duplicate of this bug. ***
*** Bug 560933 has been marked as a duplicate of this bug. ***
*** Bug 561936 has been marked as a duplicate of this bug. ***