GNOME Bugzilla – Bug 557152
Popup menus need placeholders for plugin items. Properties should always be at bottom.
Last modified: 2008-11-10 20:09:03 UTC
Because there is not a placeholder on some of the popup menus, adding items from a plugin adds them below the properties menu item, which should always be last.
Add *PluginPlaceholder to all Popup menus. Patch to rhythmbox-ui.xml forthcoming.
Created attachment 120960 [details] [review]
Adds *PluginPlaceholder to all Popup menus in data/ui/rhythmbox-ui.xml
created from HEAD
Created attachment 120972 [details]
screenshot showing before and after effects of the patch with an updated (jump-to-playing) plugin
I'm only currently aware of 2 plugins needing updating.
I've updated the jump-to-playing plugin here: http://www.stevenbrown.ca/blog/archives/437
Other plugins that need updating:
- Open Containing Folder
I'll send a patch to the author shortly, I suppose.
Created attachment 121079 [details] [review]
Adds Open Folder to PodcastView, QueuePlaylistView, and PlaylistView popups and puts the item in the placeholder
This should be applied to version 0.2 of the plugin, available here: http://www.infinicode.org/code/rb/
Created attachment 121161 [details]
Image of patched RB and 2 updated plugins using it
Attached an image of a patched RB and 2 updated plugins using it. Looks much better with Properties always at the bottom, I think! :)
I've just uploaded a new version of the Open Folder plugin, with the patch from Steven Brown. Thank you very much for it.
There's actually no reason to call these things 'QueuePlaylistViewPopupPluginPlaceholder' and so on. I've changed all the names to just PluginPlaceholder (including for existing placeholders) and committed it. Thanks.
Created attachment 122347 [details] [review]
patch to apply to rb-open-folder 0.3 to account for changes
Adolfo, here's a patch you can apply to 0.3 of your plugin to account for these changes.
I agree! :) I was just trying to follow the existing standard.
Updated jump-to-playing plugin appropriately here: http://www.stevenbrown.ca/blog/archives/437
rb-open-folder updated to 0.4. Thanks Steven.