GNOME Bugzilla – Bug 557061
Alpha to Logo
Last modified: 2009-05-21 16:52:43 UTC
Please describe the problem: Cool Metal error messages 1.Plug-In 'Cool Metal' left image undo in inconsistent state, closing open undo groups. 2.Error while executing script-fu-cool-metal-logo-alpha: Error: Procedure execution of gimp-floating-sel-to-layer failed on invalid input arguments: Cannot convert this layer to a normal layer because it is not a floating selection. Steps to reproduce: 1. New - enter text 2. goto alpha to logo & select Cool metal 3. click on OK Actual results: 2 error messages above Expected results: Does this happen every time? YES Other information: I am using Ubuntu 8.04 AMD64. Previous version never had a problem before the 2.6 upgrade when it was XTNS - Logos etc.
On Windows, using GIMP 2.6.1, this does even crash GIMP (and not only script-fu).
The text entry line remains greyed out. Previously it was possible to use the Alpha to Logo as a stand alone. Now everything is greyed unless you start New - Text, and then the text entry lines are not active.?
No idea what your second comment is supposed to tell us.
The crash on Windows comes from trying to printf NULL as %s:
+ Trace 208600
279 280 if (cleanup->undo_group_count != image->group_count) 281 { 282 GimpProcedure *proc = proc_frame->procedure; 283 284 g_message ("Plug-In '%s' left image undo in inconsistent state, " 285 "closing open undo groups.", 286 gimp_plug_in_procedure_get_label (GIMP_PLUG_IN_PROCEDURE (proc))); 287 288 while (image->pushing_undo_group != GIMP_UNDO_GROUP_NONE && (gdb) p proc $1 = (GimpProcedure *) 0x0
Gah, my fault. I added code that sets proc_frame->procedure to NULL in my last patch to this file. will fix.
Fixed the crash on windows but not the actual bug: 2008-10-23 Michael Natterer <mitch@gimp.org> * app/plug-in/gimppluginprocframe.c (gimp_plug_in_proc_frame_dispose): set proc_frame->procedure to NULL *after* calling gimp_plug_in_cleanup(). Fixes the crash on windows in bug #557061 (but not the bug).
Hi, I'm new here. I can confirm that this bug still exists in 2.6.3 (and 2.6.2). The error shows up when choosing Cool Metal from the Filter/Alpha-to-Logo path after using the Text tool, as initially pointed out by Terry above, and the same error messages will appear. But Cool Metal does work if chosen from the other path, File/Create/Logo. This is using Gimp 2.6 under Windows XP/Home SP3, Mobile Pentium 4. For more info, I wrote some posts in http://gimptalk.com/forum/gimp-2-6-3-released-t35771.html
Created attachment 134939 [details] [review] Fix floating selection test
This should be committed to both branches before the next 2.6 release.
Thanks for the fix, I have pushed this to both branches: commit 35ac02e66d177db4094f655ba26bf40a0f01bf43 Author: Sven Neumann <sven@gimp.org> Date: Thu May 21 18:49:51 2009 +0200 Bug 557061 – Alpha to Logo Applied patch from Eric Lamarque fixing an error in the Cool Metal Logo script. plug-ins/script-fu/scripts/coolmetal-logo.scm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)