After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556904 - Darwin support is broken
Darwin support is broken
Status: RESOLVED FIXED
Product: libgtop
Classification: Core
Component: darwin
2.24.x
Other All
: Normal major
: ---
Assigned To: libgtop maintainers
libgtop maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-19 03:22 UTC by Marc-Andre Laperle
Modified: 2011-09-08 07:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the problem (376 bytes, patch)
2008-10-19 03:23 UTC, Marc-Andre Laperle 		none Details | Review
a stub is just as good if it builds, right?! (3.70 KB, patch)
2009-01-09 18:21 UTC, paul 		committed Details | Review
Darwin proclist.c patch (716 bytes, patch)
2011-09-08 02:32 UTC, Marc-Andre Laperle 		committed Details | Review

Description Marc-Andre Laperle 2008-10-19 03:22:21 UTC 
Please describe the problem:
"sysdeps.c:50: error: 'GLIBTOP_SUID_PROC_AFFINITY' undeclared here (not in a function)
make[3]: *** [sysdeps.lo] Error 1"

libgtop doesn't compile on darwin, there is a declaration missing in sysdeps/darwin/glibtop_server.h


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Marc-Andre Laperle 2008-10-19 03:23:20 UTC 
Created attachment 120853 [details] [review]
Patch to fix the problem
Comment 2 Marc-Andre Laperle 2008-10-19 04:28:40 UTC 
Nevermind, the patch is invalid as it produces an error in dynamic linking. The problem is still there.
Comment 3 paul 2009-01-09 18:21:35 UTC 
Created attachment 126130 [details] [review]
a stub is just as good if it builds, right?!
Comment 4 Benoît Dejean 2009-01-12 21:14:55 UTC 
Yep it is. Send more patches :]

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 5 paul 2009-01-13 05:27:21 UTC 
this needs commited on trunk too
Comment 6 Jasper Lievisse Adriaanse 2011-08-30 16:30:14 UTC 
To me it seems that d541cf22ef2efd8caa9f4b5a46b043ccb4ff77bc should fix your issue. Could you please confirm that with a 2.28.x release?
Comment 7 Marc-Andre Laperle 2011-09-08 02:32:25 UTC 
Created attachment 195945 [details] [review]
Darwin proclist.c patch

It doesn't compile now because glibtop_get_proclist_p doesn't match the header.
Comment 8 Jasper Lievisse Adriaanse 2011-09-08 07:27:22 UTC 
Review of attachment 195945 [details] [review]:

Committed as d1d565aa608ae7a143e99231063a04018096ca58