After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556608 - Monitor color profile is not applied to filter preview
Monitor color profile is not applied to filter preview
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: libgimp
git master
Other All
: Normal enhancement
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2008-10-16 19:07 UTC by Michal Lindner
Modified: 2016-10-04 18:38 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michal Lindner 2008-10-16 19:07:35 UTC
Please describe the problem:
No profile (I tested RGB and Monitor profiles) is applied to filter preview.

Steps to reproduce:
1. upload ICC profile that significantly affect colours
2. enable color managed display and select color profile in monitor
3. try some filter with preview (example: Filters/Enhance/Unsharp Mask)
4. couurs in preview will be different to image window


Actual results:
false color

Expected results:
use selected color profiles in preview mode

Does this happen every time?
yes

Other information:
GIMP 2.6.0
Comment 1 Christian Persch 2008-10-16 19:15:40 UTC
Please file bugs in the correct Product. Moving to gimp.
Comment 2 Sven Neumann 2008-10-17 06:34:13 UTC
Yes, that feature is still missing. There are other places that also still are not color managed. See bug #467930 and bug #478528. Patches to implement this are welcome.
Comment 3 kenkyee 2009-05-13 16:13:53 UTC
I can confirm this issue is still in Gimp 2.6.6 :-(
Comment 4 Michael Natterer 2009-05-13 17:09:07 UTC
Not surprising, since nobody has written a single line of code to
support it.
Comment 5 Michael Natterer 2016-05-24 19:40:02 UTC
I just realized this comes almost for free when making color
selectors color managed, setting milestone.
Comment 6 Michael Natterer 2016-05-24 19:46:28 UTC
Some preparation:

commit 9c99d61febd808925bf9152b09f7344ad91c89ea
Author: Michael Natterer <mitch@gimp.org>
Date:   Tue May 24 21:43:20 2016 +0200

    libgimpwidgets: add gimp_preview_area_set_color_config()
    
    If a config is set, apply its settings when drawing the preview's
    pixels. This is preparation for fixing:
    
    Bug 467930 - color selectors are not color managed
    Bug 556608 - Monitor color profile is not applied to filter preview

 libgimpwidgets/gimppreviewarea.c | 222 ++++++++++++++++++++++++++++++++++++++++++++++++---------
 libgimpwidgets/gimppreviewarea.h | 119 ++++++++++++++++---------------
 libgimpwidgets/gimpwidgets.def   |   1 +
 3 files changed, 252 insertions(+), 90 deletions(-)
Comment 7 Alexandre Prokoudine 2016-08-29 20:46:55 UTC
Should we close this one as resolved now, mitch?
Comment 8 Michael Natterer 2016-08-29 22:26:20 UTC
It's fixed only for the plug-ins which use GimpPreviewArea, need to
double check all plug-ins with a preview and maybe file individual
bugs for the ones which don't (if any).
Comment 9 Michael Natterer 2016-10-04 18:38:36 UTC
There aren't that many plug-ins left... I grepped quickly and it seems
we got them all (no guarantee).

Closing as FIXED.