After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556475 - support Shadows: annotation
support Shadows: annotation
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
: 573933 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-15 21:56 UTC by Colin Walters
Modified: 2015-02-07 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
support Shadows: (8.44 KB, patch)
2008-10-15 21:57 UTC, Colin Walters 		none Details | Review
Implementation of the 'Rename to' annotation (9.65 KB, patch)
2009-03-04 14:31 UTC, Andreas Rottmann 		reviewed Details | Review

Description Colin Walters 2008-10-15 21:56:48 UTC 
Per the current Annotations spec, we should support a Shadows: annotation.  This is useful for overriding C convenience varargs functions, among others.
Comment 1 Colin Walters 2008-10-15 21:57:35 UTC 
Created attachment 120684 [details] [review]
support Shadows:
Comment 2 Andreas Rottmann 2008-10-21 01:21:06 UTC 
This needs to end up in the typelib, too, right?
Comment 3 Colin Walters 2008-10-21 01:55:09 UTC 
The shadower function does - it takes over the name.  The shadowed function does not.
Comment 4 Johan (not receiving bugmail) Dahlin 2009-01-13 21:17:18 UTC 
This is referred as Rename-To: in the annotation documentation.
Comment 5 Colin Walters 2009-03-03 16:52:11 UTC 
*** Bug 573933 has been marked as a duplicate of this bug. ***
Comment 6 Andreas Rottmann 2009-03-04 14:31:25 UTC 
Created attachment 130018 [details] [review]
Implementation of the 'Rename to' annotation
Comment 7 Colin Walters 2009-03-13 16:15:16 UTC 
Looks good, you might rename the "filter_recursive" method of Namespace to e.g. "remove_matching" since to my mind "filter" implies functional/side-effect-free, but it actually mutates the node list.
Comment 8 Colin Walters 2009-03-17 21:36:07 UTC 
Did you want to commit this Andreas?
Comment 9 Andreas Rottmann 2009-03-18 09:51:19 UTC 
(In reply to comment #8)
> Did you want to commit this Andreas?
> 
Yes, didn't come around to it yet, will hopefully do later today (with the suggested changes).
Comment 10 Andreas Rottmann 2009-03-23 22:17:43 UTC 
Commited as 23e6fa6..
Comment 11 André Klapper 2015-02-07 16:58:52 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]