GNOME Bugzilla – Bug 556459
[PATCH] gnome-session-properties should filter by NoDisplay
Last modified: 2013-05-29 14:32:54 UTC
gnome-session-properties should filter by the NoDisplay key[1]. For all the same reasons it makes sense in menus, it makes sense for autostart. With NoDisplay, one can install programs that run when the user logs in, but that the user should not be allowed to disable easily. Things that would break their setup if they disabled or just don't make sense to disable. As an example, I (in Ubuntu Intrepid) have both 'xdg-user-dirs-gtk-update' and '/usr/bin/canberra-gtk-play --id="desktop-login" --description="GNOME Login"' in my list. Both should probably always run or have other ways of being controlled. As a user, I don't really desire to control whether they are autostarted or not. They are 'system-level' autostarts. Besides, respecting NoDisplay would presumably be a more correct implementation of the spec. [1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html#key-nodisplay
Created attachment 120676 [details] [review] Proposed patch Trivial patch, copyright Canonical
(In reply to comment #0) > Besides, respecting NoDisplay would presumably be a more correct implementation > of the spec. The general interpretation of the spec has been that NoDisplay means "do not display in the menus created according to the Desktop Menus Specification", and does not necessarily mean "do not display anywhere". So it's not inherently wrong to display them in the session capplet. And people may want to display some autostart things that aren't ordinary show-in-the-menus applications. But yeah, if they are going to be shown, they should at least be differentiated somehow. (shown in a separate list, shown with some special icon, only shown if you check a certain box, etc).
Long time, no reply. :) Dan, I agree that since we're in the session capplet, and not a desktop menu like the spec intended, we don't have to treat all keys the same. But I still think respecting NoDisplay makes sense in this context. The list is clearly full of entries that are really not intended for the casual user (User Folders Update, Gnome Settings Daemon, Keyring Daemon). And since the session capplet uses a different directory (and hence different files) from the normal desktop menu, there's no conflict with an application wanting to not display in the main menu but display in the session capplet. Just set NoDisplay in one and not the other.
Created attachment 146469 [details] [review] updated patch against 2.28.0
Can this be reviewed please? I accidentally removed gnome-settings-daemon some days ago :S Thanks a lot
Any news on this?
Comment on attachment 146469 [details] [review] updated patch against 2.28.0 yea makes sense, I think.
commit 55fab9dc066875641cffbab966ca20e35821afdf Author: Michael Terry <michael.terry@canonical.com> Date: Wed May 29 10:31:30 2013 -0400 capplet: Don't show desktop files with NoDisplay=true https://bugzilla.gnome.org/show_bug.cgi?id=556459