After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556263 - Deprecate GtkCurve
Deprecate GtkCurve
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.19.x
Other All
: Normal normal
: ---
Assigned To: Christian Dywan
gtk-bugs
deprecations
Depends on:
Blocks:
 
 
Reported: 2008-10-14 13:14 UTC by Christian Dywan
Modified: 2011-02-04 16:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Deprecate GtkCurve and GtkGammaCurve (6.44 KB, patch)
2008-10-14 14:02 UTC, Christian Dywan
needs-work Details | Review
Deprecate GtkCurve and GtkGammaCurve, 2nd attempt (9.62 KB, patch)
2008-10-24 10:11 UTC, Christian Dywan
committed Details | Review
Deprecate GtkCurveType (483 bytes, patch)
2009-11-27 16:50 UTC, Christian Dywan
committed Details | Review

Description Christian Dywan 2008-10-14 13:14:46 UTC
As of now there's doesn't seem to be much benefit in having GtkCurve in Gtk, it's not usually considered useful by most people nad not used much.

As such, GtkCurve should be deprecated.

If anyone likes to use it I suggest it could go into the hypothetical legacy library that is planned to contain a few deprecated widgets for use in Gtk 3.
Comment 1 Christian Dywan 2008-10-14 14:02:47 UTC
Created attachment 120571 [details] [review]
Deprecate GtkCurve and GtkGammaCurve

This patch deprecates GtkCurve, and also its subclass GtkGammaCurve.
Comment 2 Michael Natterer 2008-10-21 13:53:05 UTC
The single-include guards needs to be changed the way the other deprecated
headers are done.

gtk.h needs some reordering, deprecated headers are at the end

Makfile.am: likewise
Comment 3 Christian Dywan 2008-10-24 10:11:09 UTC
Created attachment 121255 [details] [review]
Deprecate GtkCurve and GtkGammaCurve, 2nd attempt

Thank your for the pointers, I revised the included guards so that they match other widgets and changed gtk.h and Makefile.in accordingly.
Comment 4 Christian Dywan 2009-09-05 22:42:08 UTC
Any chance to get this in? Mitch?
Comment 5 Christian Dywan 2009-10-21 16:17:52 UTC
Comitted to master.
Comment 6 Andrew Cowie 2009-10-22 00:45:15 UTC
Should we be getting rid of GtkCurveType as well?

AfC
Comment 7 Christian Dywan 2009-11-27 16:50:41 UTC
Created attachment 148606 [details] [review]
Deprecate GtkCurveType
Comment 8 Javier Jardón (IRC: jjardon) 2010-02-07 00:55:56 UTC
Comment on attachment 148606 [details] [review]
Deprecate GtkCurveType

commit 5adb75f26b481b3d0677a5d165d6b82e4cc19e2d
Comment 9 Javier Jardón (IRC: jjardon) 2010-02-07 00:56:18 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release.