After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556091 - libtool-2.2 and old gettext don't mix
libtool-2.2 and old gettext don't mix
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Cygwin
: Normal blocker
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-13 04:12 UTC by Yaakov Selkowitz
Modified: 2008-11-29 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
autopoint-0.17 patch (1.10 KB, patch)
2008-10-13 21:02 UTC, Yaakov Selkowitz
committed Details | Review
new common/gettext.patch (337 bytes, patch)
2008-10-13 21:05 UTC, Yaakov Selkowitz
committed Details | Review

Description Yaakov Selkowitz 2008-10-13 04:12:13 UTC
The old gettext macros used in current GStreamer packages clobbers variables in libtool-2.2, causing linking problems on Cygwin where a (sub-)dependency library is from w32api.  I've explained this at length on the cygwin list:

http://cygwin.com/ml/cygwin/2008-10/msg00271.html

AFAICS the solution would be to require gettext-0.17 (instead of the five-year-old 0.11.5) in autogen.sh and configure.ac for each package, and recreate common/gettext.patch (the first hunk applies with fuzz and offset; the second hunk is obsolete).
Comment 1 Sebastian Dröge (slomo) 2008-10-13 09:40:52 UTC
gettext 0.17 is ~1 year old now. I guess that's old enough for a build-time-only dependency.

Is AM_GNU_GETTEXT_VERSION([0.17]) enough for this bug or should gettext.m4 also be updated from gettext 0.17?
Comment 2 Daniel Macks 2008-10-13 09:51:22 UTC
Is 0.17 needed to build packages that are already autoconf'ed, or is it just an autoconf requirement? The problem description sounds like the latter (new gettext.m4 is used to generate the aclocal.m4 and then into configure) not the former. If so, seems like the version-requirement goes in autogen.sh or somesuch, and that forcing *compile-time* use of 0.17 from a source-dist that already has configure created is (nice to be up-to-date but) overly strict.
Comment 3 Yaakov Selkowitz 2008-10-13 21:02:41 UTC
Created attachment 120531 [details] [review]
autopoint-0.17 patch

Re: comment 1
> Is AM_GNU_GETTEXT_VERSION([0.17]) enough for this bug or should gettext.m4 
> also be updated from gettext 0.17?

In each package, autogen.sh and configure.ac should be patched as attached...
Comment 4 Yaakov Selkowitz 2008-10-13 21:05:00 UTC
Created attachment 120533 [details] [review]
new common/gettext.patch

... then replace common/gettext.patch with this attachment.
Comment 5 Yaakov Selkowitz 2008-10-13 21:09:01 UTC
Re: comment 2
> Is 0.17 needed to build packages that are already autoconf'ed, or is it just 
> an autoconf requirement? The problem description sounds like the latter (new
> gettext.m4 is used to generate the aclocal.m4 and then into configure) not the
> former. If so, seems like the version-requirement goes in autogen.sh or
> somesuch, and that forcing *compile-time* use of 0.17 from a source-dist that
> already has configure created is (nice to be up-to-date but) overly strict.

0.17 is only be a requirement for the developers running autogen.sh, or users using a CVS checkout.  This should not negatively impact users using tarballs.
Comment 6 Sebastian Dröge (slomo) 2008-11-29 09:13:17 UTC
We should probably get this done before next releases as libtool 2.2 is fairly common in recent distros I guess
Comment 7 Sebastian Dröge (slomo) 2008-11-29 13:26:52 UTC
2008-11-29  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Patch by: Cygwin Ports maintainer
                   <yselkowitz at users dot sourceforge dot net>

        * gettext.patch:
        Update the gettext patch for use with gettext 0.17 which is
        required to build with libtool 2.2 because of conflicts.
        First part of bug #556091.
Comment 8 Sebastian Dröge (slomo) 2008-11-29 13:28:55 UTC
2008-11-29  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Patch by: Cygwin Ports maintainer                          
                  <yselkowitz at users dot sourceforge dot net>

        * autogen.sh:
        * configure.ac:
        Require gettext 0.17 because older versions don't mix with libtool
        2.2. At build time an older gettext version will still work.
        Fixes bug #556091.