After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556074 - Should check for GST_TAG_PREVIEW_IMAGE when thumbnailing audio
Should check for GST_TAG_PREVIEW_IMAGE when thumbnailing audio
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: GStreamer backend
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: Maintainer alias for GStreamer component of Totem
Maintainer alias for GStreamer component of Totem
Depends on:
Blocks:
 
 
Reported: 2008-10-13 00:08 UTC by John Millikin
Modified: 2008-10-14 03:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
If no IMAGE tag can be found, check for PREVIEW_IMAGE (782 bytes, patch)
2008-10-13 00:15 UTC, John Millikin 		none Details | Review
If no IMAGE tag can be found, check for PREVIEW_IMAGE (790 bytes, patch)
2008-10-13 00:39 UTC, John Millikin 		committed Details | Review

Description John Millikin 2008-10-13 00:08:51 UTC 
bacon_video_widget_get_best_image() checks for the GST_TAG_IMAGE GStreamer tag, but not GST_TAG_PREVIEW_IMAGE. This means that some file types are not thumbnailed even though GStreamer supports them.
Comment 1 John Millikin 2008-10-13 00:15:21 UTC 
Created attachment 120481 [details] [review]
If no IMAGE tag can be found, check for PREVIEW_IMAGE
Comment 2 Bastien Nocera 2008-10-13 00:32:17 UTC 
I think your patch is reverted, and probably not _actually_ checking for PREVIEW_IMAGE at all...
Comment 3 John Millikin 2008-10-13 00:39:10 UTC 
Created attachment 120482 [details] [review]
If no IMAGE tag can be found, check for PREVIEW_IMAGE

> I think your patch is reverted, and probably not _actually_ checking for
PREVIEW_IMAGE at all...

Oh, yes, it would be good if I could diff against the correct files.
Comment 4 Bastien Nocera 2008-10-13 00:45:05 UTC 
Looks fine to me, please commit to trunk and gnome-2-24.
Comment 5 John Millikin 2008-10-13 00:46:08 UTC 
I don't have commit permission, sorry.
Comment 6 Bastien Nocera 2008-10-13 09:38:06 UTC 
2008-10-13  Bastien Nocera  <hadess@hadess.net>

        * src/backend/bacon-video-widget-gst-0.10.c
        (bacon_video_widget_get_best_image): Patch from John Millikin
        <jmillikin@gmail.com> to also look for the GST_TAG_PREVIEW_IMAGE
        tag when trying to get audio file covers (Closes: #556074)
Comment 7 John Millikin 2008-10-14 03:25:32 UTC 
Looks like I need to eat a bit of crow. The issue that the patch "solved" for me has re-surfaced. While poking around in the thumbnailer, I noticed that there is already a check for PREVIEW_IMAGE in ``bvw_get_metadata()``. Still poking around to determine the true cause, but the extra check in the patch is merely dead weight.

Apologies for wasting your time, Mr. Nocera.