After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556050 - Improve color used in capplet
Improve color used in capplet
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
2.24.x
Other All
: Normal trivial
: ---
Assigned To: Federico Mena Quintero
Control-Center Maintainers
Depends on:
Blocks: randr-tracker
 
 
Reported: 2008-10-12 19:28 UTC by Baptiste Mille-Mathias
Modified: 2009-05-06 19:39 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
screenshot (63.01 KB, image/png)
2008-10-12 19:37 UTC, Baptiste Mille-Mathias
Details

Description Baptiste Mille-Mathias 2008-10-12 19:28:00 UTC
I seen some problems the colors used in the applet:
- The text in the rectangle displayed to located the screen is hard to read (I attach a screenshot) perhaps the background and text colors should be derivative from the theme.
- Perhaps it's a personal feeling but I don't really like the greenish color :), would be cool to use tangoish colors (see http://tango.freedesktop.org/static/cvs/tango-art-tools/palettes/Tango-Palette.png)

Perhaps it is an easy-fix if the colors are hardcoded and so I can fix it myself :)

Thanks a lot.
Comment 1 Baptiste Mille-Mathias 2008-10-12 19:37:32 UTC
Created attachment 120460 [details]
screenshot
Comment 2 Federico Mena Quintero 2009-02-26 01:42:06 UTC
The color for that little label should be set in gnome-desktop/libgnome-desktop/gnome-rr-labeler.c:create_label_window().

Can you please stick this where the label is created and test it?

  GdkColor black = { 0, 0, 0, 0 };
  gtk_widget_modify_text (label, GTK_STATE_NORMAL, &black);

(Note that the color is intended to match what gnome-display-properties uses --- which is a light background color with black text.)

Also, the palette is generated in the make_palette() function in that same file.  Feel free to tweak it to your heart's content :)

Thanks!

(Re-assigning to gnome-desktop.)
Comment 3 Federico Mena Quintero 2009-05-06 19:39:51 UTC
Fixed in the trio of death - the labels are now black against the same old pastel color:

gnome-desktop: commit 1556f925e58e97a007920e6e5376f2c61e90d3c4

gnome-settings-daemon:
  master: commit 74144fa3940471b8157e5bfb1a026fedab4340fd
  gnome-2-26: commit 8655754322a5864ba87d8bf721bdc6495a17ba17

gnome-control-center: commit af03baa1bc45fb41477c80bc045568eddd975827

The only remaining part is to use (probably) the Tango palette instead of an ad-hoc "pastel colors" palette.  If you cook a patch for GnomeRRLabeler for this, please file it in another bug :)