Bug 555956 - [NM 0.7] DNS textfield validation broken
[NM 0.7] DNS textfield validation broken
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Dan Williams
Dan Williams
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2008-10-11 21:47 UTC by rom
Modified: 2008-10-14 14:04 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---


Attachments

Description rom 2008-10-11 21:47:09 UTC
Please describe the problem:
In intrepid beta, when editing a connection, "ok" button is enabled only when all fields are ok (a tooltip should be added on this button to know what is wrong, but that's another problem).

The dns should be comma-separated, as explained in the tooltip of dns textfield:
xx.xx.xx.xx, yy.yy.yy.yy

But "ok" button becomes enabled only when dns are space(-only)-separated.
xx.xx.xx.xx yy.yy.yy.yy

And when the dialog opens, it writes dns comma-separated, so it is open with "wrong values" according to "ok" button state.

Steps to reproduce:
1. enter 2 dns for a manual connection, ok accepts only if they are space-separated
2. validate
3. edit the connection : dns are comma-separated, and "ok" button is disabled
4. remove the ',' between dns, now it's ok!


Actual results:


Expected results:


Does this happen every time?
yes

Other information:
Comment 1 Dan Williams 2008-10-13 02:16:58 UTC
What exact package version of NM are you testing?  A few fixes got committed in the past week or so, so it may be that it's fixed already in trunk.
Comment 2 rom 2008-10-13 07:59:08 UTC
The exact version of my package is : 0.7~~svn20081008t224042-0ubuntu2
Comment 3 Alexander Sack 2008-10-13 19:08:55 UTC
i think the current package didn't receive that commit yet. if its not fixed in next applet update, please speak up again.
Comment 4 Alexander Sack 2008-10-13 19:26:46 UTC
ok. just checked. the patch was indeed stuck in my upload queue. I uploaded package 0.7~~svn20081012t133407-0ubuntu1 to ubuntu/intrepid now. This should fix your issue.
Comment 5 rom 2008-10-14 14:04:16 UTC
OK, it works :)

Thank you.

Note You need to log in before you can comment on or make changes to this bug.