After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 555942 - Not all public EXIF API headers are installed
Not all public EXIF API headers are installed
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other All
: Normal minor
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-11 18:50 UTC by Pierre-Luc Beaudoin
Modified: 2008-10-12 11:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Fix src/Makefile.am (407 bytes, patch)
2008-10-11 18:51 UTC, Pierre-Luc Beaudoin 		none Details | Review
Improved patch (575 bytes, patch)
2008-10-11 19:02 UTC, Pierre-Luc Beaudoin 		committed Details | Review

Description Pierre-Luc Beaudoin 2008-10-11 18:50:12 UTC 
Please describe the problem:
When compiling plugins that are using EXIF data, there are some compile warning regarding undefined functions.  We can't include the headers because they aren't installed.

Steps to reproduce:
1. Write a EOG plugin using EXIF functions
2. Compile


Actual results:
Compile warnings

Expected results:
No warnings.

Does this happen every time?
Yes

Other information:
Patch is coming up.
Comment 1 Pierre-Luc Beaudoin 2008-10-11 18:51:32 UTC 
Created attachment 120399 [details] [review]
Fix src/Makefile.am

Seems to install the missing headers.
Comment 2 Pierre-Luc Beaudoin 2008-10-11 19:02:26 UTC 
Created attachment 120401 [details] [review]
Improved patch

Install other conditional headers.
Comment 3 Claudio Saavedra 2008-10-12 11:48:10 UTC 
The only nitpicker I have is that this causes eog-exif-details.h to be intalled twice. A patch to avoid that would be welcome, but I consider that minor, so I'll commit your fix. Thank you!

2008-10-12  Claudio Saavedra  <csaavedra@igalia.com>

	* src/Makefile.am: Install metadata related headers properly.
	Fixes bug #555942 (Pierre-Luc Beaudoin)

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.