GNOME Bugzilla – Bug 555831
be able to mount a volume from recent files
Last modified: 2017-06-04 15:32:20 UTC
When you try to load a file from the recent files that is on an unmounted volume EOG will fail to load the file. It should try to mount the volume the file is on. To reproduce: 1. Create a SSH connection in nautilus and open an image over it 2. Close EOG. 3. "Unmount" the SSH connection 4. Open EOG and choose the file from the recent files list. What happens: EOG fails saying there could no images be found What should happen: EOG should try to re-mount the SSH connection possibly asking for my password.
Created attachment 351871 [details] [review] EogJobs: Try to mount volume if not already mounted It may happen for various reasons that somebody tries to open a location, which is not already mounted. Consequently, "No images found in '[location]'." error is shown to the user currently. Let's try to mount the volume in such case instead of showing the error.
The is also needed due to the proposed changes to the admin backend, Bug 771285.
Review of attachment 351871 [details] [review]: Works nice in a quick test with an SMB/CIFS share. ::: src/eog-jobs.c @@ +702,3 @@ + _g_file_mount_enclosing_volume_sync_cb, + data); + g_cond_wait (&data->cond, &data->mutex); Shouldn't this be wrapped in a loop?
Created attachment 352389 [details] [review] EogJobs: Try to mount volume if not already mounted Thanks for the review! Yes, this should be wrapped in a loop, so I am attaching an updated patch.
Thanks! :) commit beb99cfda1bfd9097e7b2ca3ec4d3950cb2b13b8 Author: Ondrej Holy <> Date: Mon May 15 10:27:03 2017 +0200 EogJobs: Try to mount volume if not already mounted It may happen for various reasons that somebody tries to open a location, which is not already mounted. Consequently, "No images found in '[location]'." error is shown to the user currently. Let's try to mount the volume in such case instead of showing the error. https://bugzilla.gnome.org/show_bug.cgi?id=555831 --- This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.