After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554663 - Swap "Save" and "Save as Draft" accelerators in composer
Swap "Save" and "Save as Draft" accelerators in composer
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other All
: Normal enhancement
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[kill-bonobo]
Depends on:
Blocks: 310552
 
 
Reported: 2008-10-02 07:43 UTC by Nick Jenkins
Modified: 2010-02-24 07:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22



Description Nick Jenkins 2008-10-02 07:43:36 UTC
Is there any chance of changing the shortcut to save a draft to be ctrl-s? In other software - word processors, spreadsheets, presentation software, other email clients, and sorth, on multiple platforms - ctrl-s means "save this file in the current format". However, if you are editing a draft mail in evolution, and press ctrl-s, then it's treated like "save as" in other applications - i.e. you have to say where you want a copy of this email saved, under what name, etc etc.

The default for ctrl-s, should, IMHO, be to save the draft. It certainly is in other email clients (e.g. Outlook). I understand that there may be some resistance to swapping ctrl-s with ctrl-shift-s, but ctrl-s is such a standard that it has a standardized meaning - save this now, without prompting (if at all possible), in the same format (i.e. it was a draft email, so therefore I want it saved as a draft email) - and evolution does not seem to be following this commonly understood meaning of ctrl-s.

Other information:
Comment 1 André Klapper 2008-10-03 17:45:41 UTC
So you propose using Control+Shift+S in entire evolution for saving a message to a file?

(For future reference, please file enhancements as enhancements.)
Comment 2 Matthew Barnes 2008-10-03 18:24:09 UTC
I'm inclined to agree with the reporter.  For cases where we /can't/ save without prompting, Ctrl+Shift+S seems more appropriate.  That would apply to pretty much all the right-click menus with a "Save As..." option.  But the editors (not just the composer) should continue using Ctrl+S to save without prompting.

On a related note, it would be nice if the "save-to-disk" options indicated the file format to be used.  Contacts already does this with "Save as vCard...".  The rest should follow suit: "Save as mbox...", "Save as iCalendar...".
Comment 3 Matthew Barnes 2008-10-03 18:26:31 UTC
I'd like a second (or third) opinion on this before I bother with a patch, though.  I can already feel the backlash from users used to the old bindings.
Comment 4 Nick Jenkins 2008-10-21 06:39:42 UTC
> So you propose using Control+Shift+S in entire evolution for saving a message 
> to a file?

Ctrl-Shift-S as "save with prompting", Ctrl-S as "save without prompting" (and if that's not possible, treat as if user had done "save with prompting"). I.e. the shortest and easiest keyboard shortcut should correspond to the quickest and most-common use-case, in keeping with other apps.

> (For future reference, please file enhancements as enhancements.)

My apologies, I followed the gnome bug-logging wizard and it said "usability" = "this is a suggestion for how the application could be made easier to use", which (to me) honestly seemed the most applicable description; I really wasn't trying to miscategorize.

> it would be nice if the "save-to-disk" options indicated the
> file format to be used.  Contacts already does this with "Save as vCard...". 
> The rest should follow suit: "Save as mbox...", "Save as iCalendar...".

Agreed, and logged as bug 557188.

> I'd like a second (or third) opinion on this

Agreed. I'm certain it's a better UI, and it's more consistent with other apps (both in Linux and elsewhere). The only question is whether "gain from happier future + current users due to standardised keyboard shortcut > pain from current users who use + prefer the current non-standardised keyboard shortcut". If yes, then it should be done, if not, then this should be closed as wontfix. The trouble is that future users are by their very nature silent, and current users who prefer the current keyboard shortcut are likely to be silent, and most people don't log bugs or comment on existing bugs, and so unfortunately that doesn't leave very many people to express an opinion, either for or against.
Comment 5 Roman Friesen 2010-01-20 11:45:25 UTC
The related Ubuntu bug (paper cut) report, 
https://bugs.launchpad.net/hundredpapercuts/+bug/424416 :

"Evolution "Ctrl+S" should save an email as a draft.
Currently Evolution has the following short keys for saving:
- "Ctrl + S" for saving as a file
- "Shift + Ctrl + S" for saving as a draft
But the common way is exactly the other way around:
- "Ctrl + S" for saving as a draft
- "Ctrl + Shift + S" for saving as a file
"Saving as a draft" is used very-very often, "Saving as a file" is used very-very seldom. So every time if you want to save the e-mail as a draft, you will perform "Ctrl + S" (as used to use that in MS Outlook) and will get the "save a file"-dialog - very annoying!
This bug affects all Ubuntu users using Evolution, is easy to fix - a real PAPER CUT :)"

Can you please talk to Ubuntu's paper cut team or other way around? They have confirmed this usability issue. Or just fix it ;) Thanks.
Comment 6 Matthew Barnes 2010-02-16 12:50:24 UTC
Thanks for bringing this up on the mailing list again, I'd had forgotten about it.  I've swapped the "Save" and "Save as Draft" shortcuts for Evolution 2.29.91.  The save options could probably use some rearranging and/or rewording, but that will have to wait since we're supposed to be under a UI freeze now.

http://git.gnome.org/browse/evolution/commit/?id=d7dbab49b5b3f8603286fa5c54332b93bbeca9d6
Comment 7 Nick Jenkins 2010-02-18 03:21:48 UTC
Thank you, that's fantastic news, and looking forward to this in 2.30!
Comment 8 Vish 2010-02-22 19:11:38 UTC
hi.. This bug was fixed in evolution 2.29.91 .. 
But since Ubuntu is sticking with 2.28 for Lucid LTS. 
Could the evolution devs commit the patch for evolution 2.28 too , before a new 2.28 tarball next week?   

It was also mentioned earlier that the string freeze doesnt affect this since technically it doesn't change a string, it just switch 2 existent ones rather.
Comment 9 Milan Crha 2010-02-23 15:36:55 UTC
Created commit fa52744 in evo gnome-2-28 (2.28.3+)
Comment 10 Vish 2010-02-24 07:10:43 UTC
(In reply to comment #9)
> Created commit fa52744 in evo gnome-2-28 (2.28.3+)

thanks.