After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554616 - Problems accessing subsequent lines of cells which contain line break tags in FF3 tables
Problems accessing subsequent lines of cells which contain line break tags in...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.23.x
Other All
: Normal normal
: 2.24.2
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-10-01 20:47 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-11-08 18:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
revision 1 (1.33 KB, patch)
2008-11-05 19:57 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review
rest of the fix (8.58 KB, patch)
2008-11-06 19:09 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-10-01 20:47:28 UTC
Steps to reproduce:

1. Navigate to http://www.nvda-project.org/wiki/Snapshots

2. Attempt to move down to the line which contains the 'portable archive' links using Down Arrow or Orca's table cell navigation.

Expected results: You would succeed.

Actual results: You skip over that line. You can reach it by Up Arrowing (or Tab/Shift+Tab'ing).
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-11-05 18:37:29 UTC
I see what's going on here. Assigning to myself.
Comment 2 Joanmarie Diggs (IRC: joanie) 2008-11-05 19:57:05 UTC
Created attachment 122054 [details] [review]
revision 1

Pylinted, regression tested. Seems to work. Please test.
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-11-05 21:49:09 UTC
I was chatting with Will about this after I saw Michael Weaver's message about difficulty applying patches. Will and I agreed that it was worth checking into trunk so that Michael and others can test it. After it's had more testing and seems to be sound, then we can commit it to the gnome-2-24 branch as well.

In keeping with our team notation, "testing required" indicates it has not been committed. So changing to "pending" but please test all the same. :-)
Comment 4 Joanmarie Diggs (IRC: joanie) 2008-11-06 14:28:53 UTC
I just saw Hermann's comment on the list. The patch solves the problem for arrowing up and down (i.e. just pressing Up or Down Arrow). I just tested it again, and I can always use the arrow keys to reach the line that contains the second installer. Since it is on a separate line, it is not read on the same line as the first installer.

I forgot about modifying structural navigation so that Alt+Shift+Arrows would read the entire cell. Sorry!
Comment 5 Joanmarie Diggs (IRC: joanie) 2008-11-06 19:09:42 UTC
Created attachment 122144 [details] [review]
rest of the fix

This addresses the reading of the full cell. It is a very minor change so I went ahead and committed it to trunk. Also created a table cell navigation regression test.
Comment 6 Mike Pedersen 2008-11-08 16:43:25 UTC
Tested with both FF 3.0 and 3.1. 
Comment 7 Joanmarie Diggs (IRC: joanie) 2008-11-08 18:49:57 UTC
Thanks Mike. Based on your testing, both patches have been committed to the gnome-2-24 branch as well. Closing as FIXED.