After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 553940 - provide undo for destructive actions
provide undo for destructive actions
Status: RESOLVED OBSOLETE
Product: hamster-applet
Classification: Deprecated
Component: general
0.1.6.1
Other All
: Normal enhancement
: ---
Assigned To: hamster-applet-maint
hamster-applet-maint
: 616646 617683 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-09-26 13:17 UTC by rom
Modified: 2012-09-24 18:25 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement



Description rom 2008-09-26 13:17:30 UTC
I just installed hamster-applet (included in gnome 2.24) on gnome 2.22 (in ubuntu-hardy) : this applet does exactly what I need :)

Just a little feature request : when pressing "del", it removes the task without any confirmation. An option in "preferences" panel for "asking for confirmation" would be fine.
Comment 1 Callum McKenzie 2008-09-29 20:00:48 UTC
Moving to the hamster-applet product rather than the general gnome-applets product so the correct people get to see this.
Comment 2 Toms Bauģis 2008-09-29 20:09:00 UTC
instead of confirmation, we should have one step undo (well, multiple would be even better, but one should be good enough)
Comment 3 Patryk Zawadzki 2008-09-29 20:14:05 UTC
If you mean deletion from the task list, it should not be destructive (the facts should remain in the DB, only the autocomplete list should be affected). If you mean removing acitivities from history then yes, we should be asking for confirmation (and get a proper "delete" button next to "edit").
Comment 4 Toms Bauģis 2008-09-29 20:18:34 UTC
Hmmm, now you got me all confused :)

As for activity list (we should settle up on this term for activities/tasks/whatever that is in preferences) - they got removed only if there is no fact attached, and resurrected on manual input

As for facts - we should have undo, not confirmation, because confirmation dialogs are of zero value and tend to get into blind spot really fast.
Comment 5 Ashton Kemerling 2009-04-22 16:55:45 UTC
I feel that an undo option makes only sense for applications that you work with for a long time (i.e. a word application). For an applet, I feel that a confirmation about whether or not to delete an item makes more sense. 

If we do want to make it an undo, then we have to tangle with two questions:
1) How long to keep track of the undo data.
2) How many changes to keep track of.
Comment 6 Toms Bauģis 2009-04-22 17:40:05 UTC
I'd prefer to have one undo for the most recent delete. Pretty much how gmail does it with "archive". 

Popups pose several problems - it get's in the way of user's flow and people develop notification-blindness really fast. Also, as per hig - an confirmation is in order when actions to reverse the damage would take longer than five minutes.

I think the prompt could be put to the right of the "Today" grouper errm triangle thingy.

That would be awesome, don't you think?! :)
Comment 7 Patryk Zawadzki 2009-04-22 18:45:56 UTC
I don't think popups to confirm a click break the flow. I guess they are part of the flow no matter how uncomfortable that flow is :)

Having said that, I agree that one undo level should be enough. probably even hide it after a while not to take up space in the interface (they don't mean much after a couple of minutes anyway as you need to click "Undo" and then look for changes - as soon as you lose the context, having te option to undo something you did an hour ago is meaningless). Hamster is not a "primary" task you perform after all.
Comment 8 Brandon Simmons 2009-11-23 20:59:32 UTC
Deleting a task isn't something that is part of the normal workflow when using the applet, so a confirmation box is fine. Putting the delete button right next to the edit button is an absurd choice, especially without any confirmation. 

Whoops there go all of the records of my work hours for the last two weeks. Very lame.
Comment 9 Toms Bauģis 2009-11-23 23:27:23 UTC
Deleting activities does not remove facts, thus your work hours for the last two weeks are not going anywhere.
Comment 10 Toms Bauģis 2010-04-23 13:48:44 UTC
*** Bug 616646 has been marked as a duplicate of this bug. ***
Comment 11 Toms Bauģis 2010-05-04 20:33:48 UTC
*** Bug 617683 has been marked as a duplicate of this bug. ***
Comment 12 Mezimezim 2010-05-05 02:10:20 UTC
Sorry if I post twice, but the other bug (617683) seems to have been merged with this one.

I am a user (not a developer) and I did by mistake delete some important data. Is there any way I can recover this data, it included several hours dating
all the was back to last March, and it was important to me ($$) ?

Also, I think having both an undo and a pop-up button couldn't hurt, along with an actual trashcan button. The pop-up could have give the option "do not show in the future".
Comment 13 Toms Bauģis 2012-09-24 18:25:24 UTC
moved to https://github.com/projecthamster/hamster/issues/4