After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 553762 - gnome-display-properties cores when XRANDR extension not available
gnome-display-properties cores when XRANDR extension not available
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
git master
Other All
: Normal critical
: ---
Assigned To: Soren Sandmann Pedersen
Control-Center Maintainers
: 557723 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-09-25 10:53 UTC by Matt Keenan (IRC:MattMan)
Modified: 2008-10-24 16:09 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
Patch (1.20 KB, patch)
2008-09-25 10:54 UTC, Matt Keenan (IRC:MattMan)
committed Details | Review

Description Matt Keenan (IRC:MattMan) 2008-09-25 10:53:00 UTC
Steps to reproduce:
1. Launch gnome-display-properties on a machine with X Server that does not
   provide XRANDR extension (e..g Sparc machine running XSun)
2. gnome-display-properties cores.



Stack trace:
core 'core' of 19540:	gnome-display-properties
 ff2c766c _lwp_kill (6, 0, 5, 6, ffffffff, 6) + 8
 ff24f5a4 abort    (0, 1, 6, ff35ff00, 10f19c, 0) + 108
 feb54038 g_logv   (1aac8, 6, 5, 6, 4, febf6c48) + 484
 feb54064 g_log    (1aac8, 4, 1ac6c, 15400, 18b20, fa9b57b8) + 1c
 00017eb8 run_application (1a800, 1ac00, 21d0, a4850, febf6c48, 1a800) + 70
 000182c0 main     (1ac00, ffbffaf4, 1ac00, 1ac00, 1ac00, 1ac00) + 54
 00015008 _start   (0, 0, 0, 0, 0, 0) + 108

Other information:
The crash is simply occuring due to g_error() call stating "Cannot get screen info".

This is really useless information to the user. The message should be a warning
and the application should exit gracefully, and provide a much more meaningful
message. Looking at the po files there is an existing message that used to exist
for capplets/display/main.c, however main.c does not exist anymore presumably 
because of a rewrite.
Comment 1 Matt Keenan (IRC:MattMan) 2008-09-25 10:54:19 UTC
Created attachment 119359 [details] [review]
Patch

Attached patch re-uses the original warning message and changes the g_error() 
to g_warning() so that the application can exit gracefully.
Comment 2 Jens Granseuer 2008-09-26 19:05:10 UTC
Thanks, committed.
Comment 3 Jens Granseuer 2008-10-24 16:09:58 UTC
*** Bug 557723 has been marked as a duplicate of this bug. ***