GNOME Bugzilla – Bug 553586
Add orientation API to GtkPaned
Last modified: 2010-07-10 03:50:37 UTC
See bug #541009. Here are the patches for GtkPaned, GtkHPaned and GtkVPaned.
Created attachment 119304 [details] [review] Patch implementing the above Add orientation API to GtkPaned, move all of GtkHPaned's and GtkVPaned's code to GtkPaned. Will do deprecations in separate commits because they imply lots of related changes.
Setting patch staus to needs-work right away because the patch changes the parent class from abstract to instantiatable, which means we can fix its default values. Do we need new (packing or whatever) defaults here? And what should they be? The approach to fix the default values depending on whether one of the old H/V subclasses was crated can be seen in the GtkBox patch attached to bug #553573
Committed a modified patch which uses the new GtkOrientable API. Leaving the bug open since deprecation needs to be discussed. Also, GtkPaned is not abstract any longer so we can change its defaults. Needs discussion too. 2008-11-07 Michael Natterer <mitch@gimp.org> Bug 553586 – Add orientation API to GtkPaned * gtk/gtkpaned.[ch]: implement the GtkOrientable interface and swallow all code from GtkHPaned and GtkVPaned. Add gtk_paned_new() which takes a GtkOrientation argument. Deprecate gtk_paned_compute_position() for good (also for GTK_COMPILATION). * gtk/gtkhpaned.[ch] * gtk/gtkvpaned.[ch]: remove all code except the constructor and call gtk_orientable_set_orientation() in init(). * gtk/gtk.symbols: add gtk_box_new().
Fixed a small glitch in the commit: 2008-11-07 Michael Natterer <mitch@imendio.com> * gtk/gtkpaned.c: argh, actually call the newly added private gtk_paned_calc_position() instead of the deprecated public version.