After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 553582 - Add orientation API to GtkSeparator
Add orientation API to GtkSeparator
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 541009
 
 
Reported: 2008-09-24 13:01 UTC by Michael Natterer
Modified: 2010-07-10 03:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch implementing the above (18.13 KB, patch)
2008-09-24 13:03 UTC, Michael Natterer 		committed Details | Review

Description Michael Natterer 2008-09-24 13:01:02 UTC 
See bug #541009.

Here are the patches for GtkSeparator, GtkHSeparator and GtkVSeparator.
Comment 1 Michael Natterer 2008-09-24 13:03:54 UTC 
Created attachment 119300 [details] [review]
Patch implementing the above

Add orientation API to GtkSeparator, move all of GtkHSeparator's and
GtkVSeparatoir's code to GtkSeparator.

Will do deprecations in separate commits because they imply lots of
related changes.
Comment 2 Matthias Clasen 2008-09-27 02:13:48 UTC 
Looks fine to me.

Please do the obvious gtk.symbols and gtk-sections.txt addition when committing.
Comment 3 Michael Natterer 2008-09-30 14:23:13 UTC 
Committed a modified patch which uses the new GtkOrientable API. Leaving
the bug open since deprecation needs to be discussed. Also, do we want
to lock the orientation for objects created with the old API?

2008-09-30  Michael Natterer  <mitch@imendio.com>

	Bug 553582 – Add orientation API to GtkSeparator

	* gtk/gtkseparator.[ch]: implement the GtkOrientable interface and
	swallow all code from GtkHSeparator and GtkVSeparator. Add
	gtk_separator_new() which takes a GtkOrientation argument.

	* gtk/gtkhseparator.c
	* gtk/gtkvseparator.c: remove all code except the constructor and
	call gtk_orientable_set_orientation() in init().

	* gtk/gtk.symbols: add gtk_separator_new().
Comment 4 Michael Natterer 2008-10-02 15:08:54 UTC 
Patch was not committed as-is, but it's still pretty much the same that
is in SVN now.
Comment 5 Michael Natterer 2008-10-07 09:02:17 UTC 
We also need to discuss changing the new instantiatable widget's defaults
(like defaulting to visible instead of invisible) before this bug
can be closed.
Comment 6 Matthias Clasen 2010-07-10 03:49:51 UTC 
Closing since we gave up on visible