After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 553426 - cancellable clarifications
cancellable clarifications
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2008-09-23 16:50 UTC by Dan Winship
Modified: 2008-09-25 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
additions to GCancellable docs (4.56 KB, patch)
2008-09-23 16:50 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2008-09-23 16:50:05 UTC 
This patch adds two clarifications to the GCancellable docs:

    1) Disconnecting from a signal that may be emitted in another thread
       is racy, and you probably need to use a closure notify to do cleanup.

    2) cancelling an async op cancels it asynchronously, not immediately
Comment 1 Dan Winship 2008-09-23 16:50:34 UTC 
Created attachment 119240 [details] [review]
additions to GCancellable docs
Comment 2 Matthias Clasen 2008-09-23 18:34:08 UTC 
Looks good to me.
Maybe Alex can give it a look too, since he wrote most of this subtle code ?
Comment 3 Alexander Larsson 2008-09-25 09:53:53 UTC 
Looks good to me.
Comment 4 Dan Winship 2008-09-25 12:05:16 UTC 
committed