GNOME Bugzilla – Bug 553407
Example Makefile.am uses obsolete INCLUDES instead of AM_CPPFLAGS
Last modified: 2008-10-03 13:02:01 UTC
Hi. I noticed that examples/Makefile.am sets INCLUDES. This causes automake warnings if you use automake -Wall: doc/reference/Makefile.am:103: `INCLUDES' is the old name for `AM_CPPFLAGS' (or `*_CPPFLAGS') It should be safe to change INCLUDES to AM_CPPFLAGS: I searched for uses of INCLUDES, and gtk-doc.make already includes both INCLUDES and AM_CPPFLAGS in its code, e.g.: GTKDOC_CC = $(CC) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) Thanks, Simon
Created attachment 119225 [details] [review] Use AM_CPPFLAGS instead of INCLUDES in examples/Makefile.am
Since which version of automake can one use AM_CPPFLAGS? I would rather change it to GTKDOC_CFLAGS which I don't see elsewhere.
AM_CPPFLAGS is used like any other make-variable here, thus it doesn't depend on any particular automake version. GTKDOC_CFLAGS would work for me too, if you prefer that. Note that you need to update both examples/Makefile.am and the gtk-doc.make file to use it. Thanks, /Simon
2008-10-03 Stefan Kost <ensonic@users.sf.net> patch by: Simon Josefsson <simon@josefsson.org> * examples/Makefile.am: * tests/bugs/docs/Makefile.am: * tests/gobject/docs-tmpl/Makefile.am: * tests/gobject/docs/Makefile.am: Use GTKDOC_CFLAGS instead of INCLUDES in Makefile.am. Fixes #553407.