After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 553407 - Example Makefile.am uses obsolete INCLUDES instead of AM_CPPFLAGS
Example Makefile.am uses obsolete INCLUDES instead of AM_CPPFLAGS
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: 1.11
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-23 14:45 UTC by Simon Josefsson
Modified: 2008-10-03 13:02 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Use AM_CPPFLAGS instead of INCLUDES in examples/Makefile.am (679 bytes, patch)
2008-09-23 14:46 UTC, Simon Josefsson
none Details | Review

Description Simon Josefsson 2008-09-23 14:45:21 UTC
Hi.  I noticed that examples/Makefile.am sets INCLUDES.  This causes automake warnings if you use automake -Wall:

doc/reference/Makefile.am:103: `INCLUDES' is the old name for `AM_CPPFLAGS' (or `*_CPPFLAGS')

It should be safe to change INCLUDES to AM_CPPFLAGS: I searched for uses of INCLUDES, and gtk-doc.make already includes both INCLUDES and AM_CPPFLAGS in its code, e.g.:

GTKDOC_CC = $(CC) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)

Thanks,
Simon
Comment 1 Simon Josefsson 2008-09-23 14:46:12 UTC
Created attachment 119225 [details] [review]
Use AM_CPPFLAGS instead of INCLUDES in examples/Makefile.am
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2008-09-23 19:23:11 UTC
Since which version of automake can one use AM_CPPFLAGS? I would rather change it to GTKDOC_CFLAGS which I don't see elsewhere.
Comment 3 Simon Josefsson 2008-09-26 09:13:23 UTC
AM_CPPFLAGS is used like any other make-variable here, thus it doesn't depend on any particular automake version.

GTKDOC_CFLAGS would work for me too, if you prefer that.  Note that you need to update both examples/Makefile.am and the gtk-doc.make file to use it.

Thanks,
/Simon
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2008-10-03 13:02:01 UTC
2008-10-03  Stefan Kost  <ensonic@users.sf.net>

        patch by: Simon Josefsson <simon@josefsson.org>

	* examples/Makefile.am:
	* tests/bugs/docs/Makefile.am:
	* tests/gobject/docs-tmpl/Makefile.am:
	* tests/gobject/docs/Makefile.am:
	  Use GTKDOC_CFLAGS instead of INCLUDES in Makefile.am. Fixes #553407.