After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 553204 - GtkMenuShell: 'insert' signal is missing.
GtkMenuShell: 'insert' signal is missing.
Status: RESOLVED DUPLICATE of bug 656565
Product: gtk+
Classification: Platform
Component: Widget: GtkMenu
2.12.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-09-22 03:08 UTC by rainwoodman
Modified: 2011-09-09 08:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.16 KB, patch)
2008-09-22 03:12 UTC, rainwoodman
none Details | Review

Description rainwoodman 2008-09-22 03:08:51 UTC
Please describe the problem:
Consider the implementation of GtkContainer.
In GtkContainer, 'add', 'remove' are RunFirst signals, and gtk_container_add just emit the signal to do the real addition. This is good because we can connect to add and remove signal to get informed whenever children are modified.

In GtkMenuShell, the situation is similar. However the implementation is different. there is no corresponding signal.

Steps to reproduce:


Actual results:


Expected results:
'insert' signal should be implement in GtkMenuShell, and perhaps someone should also review every GtkContainter subclass to make sure similiar signals are emitted.

Does this happen every time?
Yes.

Other information:
I have a patch but not yet cleaned up.
Comment 1 rainwoodman 2008-09-22 03:12:40 UTC
Created attachment 119143 [details] [review]
patch 

No ABI breakage by inmplementing the signal.

some language binding might need adjustments in order to use the new signal,
e.g. VALA will have to modify gtk-2.0.vapi.
Comment 2 Javier Jardón (IRC: jjardon) 2011-09-09 08:43:35 UTC
Thanks for taking the time to report this bug.
This particular bug has already been reported into our bug tracking system, but we are happy to tell you that the problem has already been fixed. It should be solved in the next software version. You may want to check for a software upgrade.

*** This bug has been marked as a duplicate of bug 656565 ***