GNOME Bugzilla – Bug 553203
Automatically delete old podcast episodes
Last modified: 2020-03-17 08:29:11 UTC
It would be nice if old podcasts could be automatically removed. I.e. if an episode was downloaded more than X days ago, automatically delete it.
Similarly if it has been listened to
Bulk changing the assignee to banshee-maint@gnome.bugs to make it easier for people to get updated on all banshee bugs by following that address. It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
*** Bug 605443 has been marked as a duplicate of this bug. ***
From duplicate Bug 605443 : Keeping only N episodes of each podcast would be useful.
Look to gpodder for excellent podcast lifespan management, with features such as protecting a podcast or a whole feed from automatic deletion (I want to keep my TedTalk vids forever!), specifying the lifetime of a played podcast, and setting HDD space usage limits to keep backlog from choking the machine.
*** Bug 633099 has been marked as a duplicate of this bug. ***
Created attachment 173554 [details] [review] autodelete support patch Here is a small patch for that features. Can you test/review it?
Review of attachment 173554 [details] [review]: I don't think the changes in LastfmRequest.cs are related to this issue, please leave them out of this patch. ::: src/Extensions/Banshee.Podcasting/Banshee.Podcasting/PodcastService.cs @@ +682,3 @@ + private int kept_pocasts_number_schema = keptPocastsNumberSchema.Get (); + //private SourcePage pref_page; + Please don't leave commented-out code. Same applies below. @@ +715,3 @@ + } + + /*private void UninstallPreferences () Why is that method commented out ? Shouldn't the preference be uninstalled when the extension gets disabled ? @@ +727,3 @@ + }*/ + + public static readonly SchemaEntry<int> keptPocastsNumberSchema = new SchemaEntry<int> ( The first letter of the property name should be uppercase. I'm not sure about the name, maybe something like "OldPodcastsToKeep" ? @@ +730,3 @@ + "plugins.podcasting", "kept_pocasts_number", 10, 0, 100, + "Kept pocasts number", + "Number of played podcast to kept when automatic delete option is on." should be "to keep" ::: src/Libraries/Migo/Migo.Syndication/Feed.cs @@ +544,3 @@ } + public void DeleteOldItems (int keptItemCount) variable names for method parameters should be in lower case with underscore. For example: int items_to_keep
Review of attachment 173554 [details] [review]: I don't think the changes in LastfmRequest.cs are related to this issue, please leave them out of this patch. ::: src/Extensions/Banshee.Podcasting/Banshee.Podcasting/PodcastService.cs @@ +682,3 @@ + + private int kept_pocasts_number_schema = keptPocastsNumberSchema.Get (); + //private SourcePage pref_page; Please don't leave commented-out code. Same applies below. @@ +715,3 @@ + } + + /*private void UninstallPreferences () Why is that method commented out ? Shouldn't the preference be uninstalled when the extension gets disabled ? @@ +727,3 @@ + }*/ + + public static readonly SchemaEntry<int> keptPocastsNumberSchema = new SchemaEntry<int> ( The first letter of the property name should be uppercase. I'm not sure about the name, maybe something like "OldPodcastsToKeep" ? @@ +730,3 @@ + "plugins.podcasting", "kept_pocasts_number", 10, 0, 100, + "Kept pocasts number", + "Number of played podcast to kept when automatic delete option is on." should be "to keep" ::: src/Libraries/Migo/Migo.Syndication/Feed.cs @@ +544,3 @@ } + public void DeleteOldItems (int keptItemCount) variable names for method parameters should be in lower case with underscore. For example: int items_to_keep
Created attachment 173816 [details] [review] autodelete patch new patch with feedback fixes
seems fixed with patch in 1.9.1 : http://git.gnome.org/browse/banshee/commit/?id=cfc37e03229e9fb31fa06192a16865e01f3ef064 option is in feed and not global as submited patch. ==> to closed
No, what's in master auto-archives episodes, but doesn't delete files. This should stay open, I think.
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.