After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552831 - Main Window Version menu is too narrow to be of practical use
Main Window Version menu is too narrow to be of practical use
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
0.5.x
Other All
: Normal minor
: ---
Assigned To: Stephane Delcroix
F-spot maintainers
: 560414 564273 578232 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-09-18 20:18 UTC by Karl Relton
Modified: 2009-04-07 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the problem (539 bytes, patch)
2008-09-18 20:20 UTC, Karl Relton 		none Details | Review
proper fix (5.23 KB, patch)
2008-09-25 09:13 UTC, Stephane Delcroix 		committed Details | Review

Description Karl Relton 2008-09-18 20:18:25 UTC 
Widen the Main Window Photo->Version menu

Other information:
Currently the window is so narrow that any version just displays as '...'. It should have buttons 'Original' and '(No Edits)' by default, but these can't display in such a narrow menu.
Comment 1 Karl Relton 2008-09-18 20:20:41 UTC 
Created attachment 118972 [details] [review]
Patch to fix the problem

This patch hard-codes the menu to 100pixels. Not sure if I should try and set it more cleverly, but at least with my chosen font-size it nicely does the trick.
Comment 2 Maxxer 2008-09-19 12:35:59 UTC 
thanks for your bug and for the patch, but the real fix would be changing  PhotoVersionMenu.cs in order to use ComboBox instead of the actual OptionMenu. 
so if you have the knowledge and the time to do so... you're welcome :)
Comment 3 Stephane Delcroix 2008-09-19 14:39:39 UTC 
maxxer (comment #2): the actual solution is:
- replace the version OptionMenu by Combobox
- restore the PhotoVersionMenu to no longer Ellipsize
Comment 4 Karl Relton 2008-09-20 09:47:34 UTC 
Give me a few days and I'll have a bash at doing a Combobox
Comment 5 Stephane Delcroix 2008-09-25 09:13:54 UTC 
Created attachment 119355 [details] [review]
proper fix

this is the proper fix I'm committing
Comment 6 Stephane Delcroix 2008-09-25 09:15:15 UTC 
fixed in r4444
Comment 7 Maxxer 2008-11-12 08:06:15 UTC 
*** Bug 560414 has been marked as a duplicate of this bug. ***
Comment 8 Maxxer 2008-12-12 16:29:56 UTC 
*** Bug 564273 has been marked as a duplicate of this bug. ***
Comment 9 Maxxer 2009-04-07 13:38:44 UTC 
*** Bug 578232 has been marked as a duplicate of this bug. ***