GNOME Bugzilla – Bug 552830
Port remaining gnome-vfs uses to Gio/Gvfs
Last modified: 2008-11-08 11:33:55 UTC
[kmaraas@localhost libgnomeui]$ grep GnomeVFS *.[ch] gnome-authentication-manager.c:construct_password_dialog (gboolean is_proxy_authentication, const GnomeVFSModuleCallbackAuthenticationIn *in_args) gnome-authentication-manager.c: const GnomeVFSModuleCallbackAuthenticationIn * in_args, gnome-authentication-manager.c: GnomeVFSModuleCallbackAuthenticationOut *out_args) gnome-authentication-manager.c: const GnomeVFSModuleCallbackAuthenticationIn *in_args; gnome-authentication-manager.c: GnomeVFSModuleCallbackAuthenticationOut *out_args; gnome-authentication-manager.c: GnomeVFSModuleCallbackResponse response; gnome-authentication-manager.c:static void /* GnomeVFSAsyncModuleCallback */ gnome-authentication-manager.c: GnomeVFSModuleCallbackResponse response, gnome-authentication-manager.c: GnomeVFSModuleCallbackAuthenticationIn *in_real; gnome-authentication-manager.c: GnomeVFSModuleCallbackAuthenticationOut *out_real; gnome-authentication-manager.c: g_return_if_fail (sizeof (GnomeVFSModuleCallbackAuthenticationIn) == in_size gnome-authentication-manager.c: && sizeof (GnomeVFSModuleCallbackAuthenticationOut) == out_size); gnome-authentication-manager.c: in_real = (GnomeVFSModuleCallbackAuthenticationIn *)in; gnome-authentication-manager.c: out_real = (GnomeVFSModuleCallbackAuthenticationOut *)out; gnome-authentication-manager.c:static void /* GnomeVFSModuleCallback */ gnome-authentication-manager.c: GnomeVFSModuleCallbackAuthenticationIn *in_real; gnome-authentication-manager.c: GnomeVFSModuleCallbackAuthenticationOut *out_real; gnome-authentication-manager.c: g_return_if_fail (sizeof (GnomeVFSModuleCallbackAuthenticationIn) == in_size gnome-authentication-manager.c: && sizeof (GnomeVFSModuleCallbackAuthenticationOut) == out_size); gnome-authentication-manager.c: in_real = (GnomeVFSModuleCallbackAuthenticationIn *)in; gnome-authentication-manager.c: out_real = (GnomeVFSModuleCallbackAuthenticationOut *)out; gnome-authentication-manager.c:construct_full_password_dialog (const GnomeVFSModuleCallbackFullAuthenticationIn *in_args) gnome-authentication-manager.c: GnomeVFSModuleCallbackFullAuthenticationOut *out_args, gnome-authentication-manager.c:present_full_authentication_dialog_blocking (const GnomeVFSModuleCallbackFullAuthenticationIn * in_args, gnome-authentication-manager.c: GnomeVFSModuleCallbackFullAuthenticationOut *out_args) gnome-authentication-manager.c: const GnomeVFSModuleCallbackFullAuthenticationIn *in_args; gnome-authentication-manager.c: GnomeVFSModuleCallbackFullAuthenticationOut *out_args; gnome-authentication-manager.c: GnomeVFSModuleCallbackResponse response; gnome-authentication-manager.c:static void /* GnomeVFSAsyncModuleCallback */ gnome-authentication-manager.c: GnomeVFSModuleCallbackResponse response, gnome-authentication-manager.c: GnomeVFSModuleCallbackFullAuthenticationIn *in_real; gnome-authentication-manager.c: GnomeVFSModuleCallbackFullAuthenticationOut *out_real; gnome-authentication-manager.c: g_return_if_fail (sizeof (GnomeVFSModuleCallbackFullAuthenticationIn) == in_size gnome-authentication-manager.c: && sizeof (GnomeVFSModuleCallbackFullAuthenticationOut) == out_size); gnome-authentication-manager.c: in_real = (GnomeVFSModuleCallbackFullAuthenticationIn *)in; gnome-authentication-manager.c: out_real = (GnomeVFSModuleCallbackFullAuthenticationOut *)out; gnome-authentication-manager.c:static void /* GnomeVFSModuleCallback */ gnome-authentication-manager.c: GnomeVFSModuleCallbackFullAuthenticationIn *in_real; gnome-authentication-manager.c: GnomeVFSModuleCallbackFullAuthenticationOut *out_real; gnome-authentication-manager.c: g_return_if_fail (sizeof (GnomeVFSModuleCallbackFullAuthenticationIn) == in_size gnome-authentication-manager.c: && sizeof (GnomeVFSModuleCallbackFullAuthenticationOut) == out_size); gnome-authentication-manager.c: in_real = (GnomeVFSModuleCallbackFullAuthenticationIn *)in; gnome-authentication-manager.c: out_real = (GnomeVFSModuleCallbackFullAuthenticationOut *)out; gnome-authentication-manager.c: const GnomeVFSModuleCallbackFillAuthenticationIn *in_args; gnome-authentication-manager.c: GnomeVFSModuleCallbackFillAuthenticationOut *out_args; gnome-authentication-manager.c: GnomeVFSModuleCallbackResponse response; gnome-authentication-manager.c:static void /* GnomeVFSAsyncModuleCallback */ gnome-authentication-manager.c: GnomeVFSModuleCallbackResponse response, gnome-authentication-manager.c: GnomeVFSModuleCallbackFillAuthenticationIn *in_real; gnome-authentication-manager.c: GnomeVFSModuleCallbackFillAuthenticationOut *out_real; gnome-authentication-manager.c: g_return_if_fail (sizeof (GnomeVFSModuleCallbackFillAuthenticationIn) == in_size gnome-authentication-manager.c: && sizeof (GnomeVFSModuleCallbackFillAuthenticationOut) == out_size); gnome-authentication-manager.c: in_real = (GnomeVFSModuleCallbackFillAuthenticationIn *)in; gnome-authentication-manager.c: out_real = (GnomeVFSModuleCallbackFillAuthenticationOut *)out; gnome-authentication-manager.c:static void /* GnomeVFSModuleCallback */ gnome-authentication-manager.c: GnomeVFSModuleCallbackFillAuthenticationIn *in_real; gnome-authentication-manager.c: GnomeVFSModuleCallbackFillAuthenticationOut *out_real; gnome-authentication-manager.c: g_return_if_fail (sizeof (GnomeVFSModuleCallbackFillAuthenticationIn) == in_size gnome-authentication-manager.c: && sizeof (GnomeVFSModuleCallbackFillAuthenticationOut) == out_size); gnome-authentication-manager.c: in_real = (GnomeVFSModuleCallbackFillAuthenticationIn *)in; gnome-authentication-manager.c: out_real = (GnomeVFSModuleCallbackFillAuthenticationOut *)out; gnome-authentication-manager.c: const GnomeVFSModuleCallbackSaveAuthenticationIn *in_args; gnome-authentication-manager.c: GnomeVFSModuleCallbackSaveAuthenticationOut *out_args; gnome-authentication-manager.c: GnomeVFSModuleCallbackResponse response; gnome-authentication-manager.c:static void /* GnomeVFSAsyncModuleCallback */ gnome-authentication-manager.c: GnomeVFSModuleCallbackResponse response, gnome-authentication-manager.c: GnomeVFSModuleCallbackSaveAuthenticationIn *in_real; gnome-authentication-manager.c: GnomeVFSModuleCallbackSaveAuthenticationOut *out_real; gnome-authentication-manager.c: g_return_if_fail (sizeof (GnomeVFSModuleCallbackSaveAuthenticationIn) == in_size gnome-authentication-manager.c: && sizeof (GnomeVFSModuleCallbackSaveAuthenticationOut) == out_size); gnome-authentication-manager.c: in_real = (GnomeVFSModuleCallbackSaveAuthenticationIn *)in; gnome-authentication-manager.c: out_real = (GnomeVFSModuleCallbackSaveAuthenticationOut *)out; gnome-authentication-manager.c:static void /* GnomeVFSModuleCallback */ gnome-authentication-manager.c: GnomeVFSModuleCallbackSaveAuthenticationIn *in_real; gnome-authentication-manager.c: g_return_if_fail (sizeof (GnomeVFSModuleCallbackSaveAuthenticationIn) == in_size gnome-authentication-manager.c: && sizeof (GnomeVFSModuleCallbackSaveAuthenticationOut) == out_size); gnome-authentication-manager.c: in_real = (GnomeVFSModuleCallbackSaveAuthenticationIn *)in; gnome-authentication-manager.c: const GnomeVFSModuleCallbackQuestionIn *in_args; gnome-authentication-manager.c: GnomeVFSModuleCallbackQuestionOut *out_args; gnome-authentication-manager.c: GnomeVFSModuleCallbackResponse response; gnome-authentication-manager.c:static void /* GnomeVFSAsyncModuleCallback */ gnome-authentication-manager.c: GnomeVFSModuleCallbackResponse response, gnome-authentication-manager.c: GnomeVFSModuleCallbackQuestionIn *in_real; gnome-authentication-manager.c: GnomeVFSModuleCallbackQuestionOut *out_real; gnome-authentication-manager.c: g_return_if_fail (sizeof (GnomeVFSModuleCallbackQuestionIn) == in_size gnome-authentication-manager.c: && sizeof (GnomeVFSModuleCallbackQuestionOut) == out_size); gnome-authentication-manager.c: in_real = (GnomeVFSModuleCallbackQuestionIn *)in; gnome-authentication-manager.c: out_real = (GnomeVFSModuleCallbackQuestionOut *)out; gnome-authentication-manager.c:static void /* GnomeVFSModuleCallback */ gnome-authentication-manager.c: GnomeVFSModuleCallbackQuestionIn *in_real; gnome-authentication-manager.c: GnomeVFSModuleCallbackQuestionOut *out_real; gnome-authentication-manager.c: g_return_if_fail (sizeof (GnomeVFSModuleCallbackQuestionIn) == in_size gnome-authentication-manager.c: && sizeof (GnomeVFSModuleCallbackQuestionOut) == out_size); gnome-authentication-manager.c: in_real = (GnomeVFSModuleCallbackQuestionIn *)in; gnome-authentication-manager.c: out_real = (GnomeVFSModuleCallbackQuestionOut *)out; gnome-icon-entry.c: GnomeVFSFileInfo *file_info; gnome-icon-entry.c: GnomeVFSURI *uri; gnome-icon-lookup.c: GnomeVFSFileInfo *file_info, gnome-icon-lookup.c: GnomeVFSFileInfo *file_info, gnome-icon-lookup.c: GnomeVFSFileInfo *file_info; gnome-icon-lookup.h: GnomeVFSFileInfo *file_info, gnome-icon-sel.c: GnomeVFSFileInfo *info; gnome-vfs-util.c: GnomeVFSResult result, gnome-vfs-util.c: GnomeVFSResult result; gnome-vfs-util.c: GnomeVFSFileSize bytes_read; gnome-vfs-util.c: /* TODO: could map the GError more precisely to the GnomeVFSError */ gnome-vfs-util.c: GnomeVFSResult result; gnome-vfs-util.c: GnomeVFSResult result, gnome-vfs-util.h: GnomeVFSResult error, [kmaraas@localhost libgnomeui]$ grep gnome-vfs *.[ch] gnome-authentication-manager.c:#include <libgnomevfs/gnome-vfs-module-callback.h> gnome-authentication-manager.c:#include <libgnomevfs/gnome-vfs-standard-callbacks.h> gnome-authentication-manager.c:#include <libgnomevfs/gnome-vfs-utils.h> gnome-authentication-manager.c: /* Maybe we should define some gnome-vfs stockbuttons and gnome-authentication-manager.c: * is available. Also sets the default sync and async gnome-vfs callbacks for various types gnome-authentication-manager.c: * hold the gdk lock while doing synchronous gnome-vfs calls. Otherwise gnome-authentication-manager.c: * gnome-vfs callbacks associated with various types of authentication. gnome-authentication-manager.c: * This function calls gnome_vfs_module_callback_pop() to remove all the gnome-vfs sync handlers associated gnome-file-entry.c:#include <libgnomevfs/gnome-vfs-uri.h> gnome-file-entry.c:#include <libgnomevfs/gnome-vfs-utils.h> gnome-icon-entry.c:#include <libgnomevfs/gnome-vfs-ops.h> gnome-icon-entry.c:#include <libgnomevfs/gnome-vfs-utils.h> gnome-icon-lookup.c:#include <libgnomevfs/gnome-vfs-mime-handlers.h> gnome-icon-lookup.c:#include <libgnomevfs/gnome-vfs.h> gnome-icon-lookup.c: * gnome_icon_lookup_sync() which gets this information using gnome-vfs. gnome-icon-lookup.h:#include <libgnomevfs/gnome-vfs-file-info.h> gnome-icon-sel.c:#include <libgnomevfs/gnome-vfs-ops.h> gnome-thumbnail.c:#include <libgnomevfs/gnome-vfs-utils.h> gnome-thumbnail.c:#include "gnome-vfs-util.h" gnome-thumbnail-pixbuf-utils.c:#include <libgnomevfs/gnome-vfs-ops.h> gnome-vfs-util.c:#include "gnome-vfs-util.h" gnome-vfs-util.c:#include <libgnomevfs/gnome-vfs-async-ops.h> gnome-vfs-util.c:#include <libgnomevfs/gnome-vfs-ops.h> gnome-vfs-util.c:#include <libgnomevfs/gnome-vfs-utils.h> gnome-vfs-util.h:#include <libgnomevfs/gnome-vfs-result.h> libgnomeui.h:#include <libgnomeui/gnome-vfs-util.h>
Here's my first gnome-love task :) Pulled libgnomeui from svn at http://svn.gnome.org/svn/libgnomeui/trunk/ Looking through the GIO documentation at http://library.gnome.org/devel/gio/unstable/ch01.html I'll post questions here or in #gnome-love, though suggestions/pointers are definitely welcome
Great stuff :-) Thanks for chipping in.
Alright, starting with gnome-authentication-manager.c, it looks like gnome-vfs is used for the actual authentication handling, and it'd seem GMountOperation ( http://library.gnome.org/devel/gio/stable/GMountOperation.html ) from GIO would be the proper thing to start replacing it with. I'll work with it and see what I can come up with
I don't think gnome-authentication-manager should be ported to gio. It's the gnome-vfs auth UI; gio has its own, doesn't it?
Meaning we should definitely deprecate a few more widgets in libgnome* this coming cycle I guess.
Does GMountOperation and it's authentication methods cover all the cases that gnome-authenication-manager does btw?
If I shouldn't be working on this, let me know and I'll look around for something else. In the meantime, I'm actually learning a lot (I think) which is cool. One thing that's sticking out is that it looks like GnomeVFS has gnome-vfs-standard-callbacks, but I am sort of checking to see what to use with Gio to replace it with. I'm looking into GMount and GFile. I know that Nautilus has been converted to Gio, I'm looking through http://svn.gnome.org/viewvc/nautilus/branches/gio-branch/ to get some help with things.
gnome-authenication-manager is the UI part of gnome-vfs authentication. It shouldn't be ported to gio, as that makes no sense. GIO authentication works differently and is already implemented in Gtk+ (as GtkMountOperation)
Ah, alright, thanks for the heads up. What about the other parts of libgnomui, such as the gnome-icon-entry?
Looks like we won't be removing the gnome-vfs dep from libgnomeui anyway since gnome-authentication-manager will stay... Thanks for looking at it though :-) There's work ongoing to remove use of libgnome/libgnomeui/gnome-vfs from all the other modules which is more rewarding for everyone. Feel free to join the effort and thanks for spending time on this.
No worries, I learned a lot just from scoping out the docs/source. I'll keep looking for something to work on. Thanks for the help! :)
Closing this as there's a lot of ongoing effort to just remove use of libgnome/libgnomeui all over the place. If there are any pieces of libgnomeui that are really needed we should move them elsewhere I guess?