After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552552 - File/Empty Trash does not expunge maildir folders
File/Empty Trash does not expunge maildir folders
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
evolution[disk-summary] evolution[mai...
: 573180 (view as bug list)
Depends on:
Blocks: 543389
 
 
Reported: 2008-09-16 20:58 UTC by Reid Thompson
Modified: 2009-10-09 10:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
proposed evo patch (1.78 KB, patch)
2009-10-07 08:59 UTC, Milan Crha
committed Details | Review

Description Reid Thompson 2008-09-16 20:58:21 UTC
Please describe the problem:
My setup:
I have a pop account with a filter setup to move source account email to a maildir account setup for this purpose via evo.  Deleted emails are not expunged when File/Empty Trash is invoked.  An explicit <CTRL-E> is required to expunge any deleted emails in the maildir account

Steps to reproduce:
1. setup a maildir account
2. delete emails in the maildir account
3. select File/Empty Trash


Actual results:
deleted emails are left in the maildir account folders

Expected results:
they'd be deleted

Does this happen every time?
yes

Other information:
svn head ( I just started using the maildir account several weeks/a month or so ago, and it's been like this since i created it )
Comment 1 Srinivasa Ragavan 2008-09-22 05:24:21 UTC
Reid, do you mean that it goes off only when you do Ctrl+E ? Just few doubts..

* You receive mails on pop and move to a maildir. So the move = delete+copy. Do you mean that these mails still remain in the source account?

or 

Do you mean that maildir requires explicit expunge to delete mails.

Also you Expunge the source directory or the Trash dir? 

Thanks
Comment 2 Reid Thompson 2008-09-22 12:26:24 UTC
(In reply to comment #1)
> Reid, do you mean that it goes off only when you do Ctrl+E ? Just few doubts..
> 
> * You receive mails on pop and move to a maildir. So the move = delete+copy. Do
> you mean that these mails still remain in the source account?

No, the filter move appears to work properly.
> 
> or 
> 
> Do you mean that maildir requires explicit expunge to delete mails.

Yes. 
> 
> Also you Expunge the source directory or the Trash dir? 

I normally expunge the maildir source directory.  I just tried a test expunge of the Trash dir.  The Trash dir expunge will remove the deleted emails from the source dir.  It's just that 'File/Empty Trash' does not appear to call expunge on the Trash dir.
> 
> Thanks
> 

Comment 3 Srinivasa Ragavan 2009-01-29 16:43:51 UTC
Reid, is this still valid? We have a different bug where trash fails to expunge bug #550414. Could you confirm? Thanks.   
Comment 4 Reid Thompson 2009-01-29 18:28:05 UTC
(In reply to comment #3)
> Reid, is this still valid? We have a different bug where trash fails to expunge
> bug #550414. Could you confirm? Thanks.   
> 

File/Empty Trash still does not appear to expunge my maildir account.  An explicit CTRL-E on either the source foler or the Trash folder is required.
Comment 5 Milan Crha 2009-02-25 18:26:10 UTC
is there some error message in the status bar after you try File->Empty trash?
Comment 6 Reid Thompson 2009-02-25 18:48:43 UTC
(In reply to comment #5)
> is there some error message in the status bar after you try File->Empty trash?
> 

No error message, just a message/progress noting that expunging is going on.  Local and OWA accounts are expunged, maildir account is not.
Comment 7 Akhil Laddha 2009-02-26 03:50:04 UTC
*** Bug 573180 has been marked as a duplicate of this bug. ***
Comment 8 Srinivasa Ragavan 2009-06-22 08:20:26 UTC
Reid, Just a small thing. I heard it from one of the user, that this is how it used to be for long. Is that so or was this a regression post 2.24?
Comment 9 Reid Thompson 2009-06-22 12:36:44 UTC
(In reply to comment #8)
> Reid, Just a small thing. I heard it from one of the user, that this is how it
> used to be for long. Is that so or was this a regression post 2.24?
> 

to my knowledge, File/Empty Trash has not expunged maildir directories at any point since my original post.  I've always had to select the individual maildir folders and explicitly expunge them.  I've established the habit of CTRL-E before moving on to the next folder.
Comment 10 Srinivasa Ragavan 2009-06-22 16:23:38 UTC
Ok. Is this a regression since 2.24 or wan't working even before was the main thing I wanted to ask.
Comment 11 Reid Thompson 2009-06-22 19:25:50 UTC
(In reply to comment #10)
> Ok. Is this a regression since 2.24 or wan't working even before was the main
> thing I wanted to ask.
> 

File/Empty Trash for maildir folders has never worked for me. 

I just noticed that I have this at the bottom of the original post for the bug report:

Other information:
svn head ( I just started using the maildir account several weeks/a month or so
ago, and it's been like this since i created it )
Comment 12 Milan Crha 2009-10-07 08:59:12 UTC
Created attachment 144936 [details] [review]
proposed evo patch

for evolution;

There were some consumptions in a code which were false. This fixes it.
Comment 13 Milan Crha 2009-10-07 09:00:28 UTC
Reid, if you can confirm the patch, then I'll commit for 2.28.1. Thanks.
Comment 14 Reid Thompson 2009-10-08 14:12:43 UTC
(In reply to comment #13)
> Reid, if you can confirm the patch, then I'll commit for 2.28.1. Thanks.

Patch applied and running.   Initial quick test shows that File->Empty Trash now expunges maildir directories.  If I see any negative effects in the next day or so I'll note them.

Thanks for the patch.

reid
Comment 15 Milan Crha 2009-10-09 10:02:39 UTC
Created commit 1156a3b in evo master (2.29.1+)
Created commit 05c9766 in evo gnome-2-28 (2.28.1+)

Thanks for testing.