After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552545 - leaks GpImage
leaks GpImage
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-09-16 20:23 UTC by Dominic Lachowicz
Modified: 2009-08-30 01:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.58 KB, patch)
2008-09-16 20:23 UTC, Dominic Lachowicz 		committed Details | Review
patch for the resulting NULL pointer crash (506 bytes, patch)
2009-08-19 18:19 UTC, sum1 		committed Details | Review

Description Dominic Lachowicz 2008-09-16 20:23:08 UTC 
Every image the loads leaks a GpImage, which can add up over time.
Comment 1 Dominic Lachowicz 2008-09-16 20:23:25 UTC 
Created attachment 118842 [details] [review]
patch
Comment 2 Dominic Lachowicz 2008-09-18 14:31:04 UTC 
2008-09-18  Dominic Lachowicz  <domlachowicz@gmail.com>

        * io-gdip-utils.c: Fix 2 cases where we leaked a GpImage (#552545)

--This line, and those below, will be ignored--

M    gdk-pixbuf/io-gdip-utils.c
M    gdk-pixbuf/ChangeLog
M    gdk-pixbuf/io-gdip-native.h
Comment 3 Morten Welinder 2009-08-19 17:57:06 UTC 
Causes crash.  Reopening.
Comment 4 Morten Welinder 2009-08-19 18:00:38 UTC 
13:08 < sum1> dom: can you double-check the following commit? 
http://git.gnome.org/cgit/gtk+/commit/?id=b559c7dacc4a7f8ee0e525192775eac5207e3cc4
13:09 < sum1> it seems that IStream_SetSize is being called before 
              CreateStreamOnHGlobal, which causes a NULL pointer crash
13:09 < sum1> (at around line 346 or so)
13:10 < dom> woah
13:10 < dom> give me 10 minutes
13:10 < dom> this might fix a bug in bgo
13:11 < dom> http://bugzilla.gnome.org/show_bug.cgi?id=552678
13:13 < dom> nope. what you found is a bug, but not that bug
13:13 < dom> sum1: feel free to fix. the obvious fix is correct
Comment 5 sum1 2009-08-19 18:19:04 UTC 
Created attachment 141177 [details] [review]
patch for the resulting NULL pointer crash
Comment 6 Matthias Clasen 2009-08-30 01:27:34 UTC 
Comment on attachment 141177 [details] [review]
patch for the resulting NULL pointer crash

This was already committed, it seems.