GNOME Bugzilla – Bug 552350
Orca doesn't recognize it is in a spreadsheet cell in certain builds of OOo Dev 3
Last modified: 2008-09-15 23:02:29 UTC
Steps to reproduce: 1. Launch any version of OOo Dev 3 where the frame name ends with "Beta" rather than "Calc". 2. Arrow around. Expected results: We'd recognize that we were in a spreadsheet cell and behave accordingly. Actual results: We don't recognize that we're in a spreadsheet cell because isSpreadSheetCell() does a string comparison on the frame name. As a result, we treat the spreadsheet as a Writer table.
Created attachment 118752 [details] [review] revision 1 isSpreadSheetCell() is brittle because of the string comparison and also the reliance upon a specific hierarchy being present. In my experience Calc spreadsheets have always had 65536 rows in them. My guess is that this is borrowed from the Excel tradition of doing the same. Given a table with exactly 65536 rows in it, my money is on it being a spreadsheet. :-) This patch checks for that condition. I've pylinted it and functionally tested it. The OOo Calc regression tests are in serious need of some updating so they're not the most reliable way to spot regressions atm. :-( Will please review. Thanks!
Yes! Anything to get rid of string compares where the strings are localized strings coming to us from the application. I like this fix. Commit!
Yikes I didn't get a bugzilla notification on this. With one hour until code freeze.... Committed! Phew! :-) Thanks Will. Closing as FIXED.