After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552153 - GtkModules loading with XSettings doesn't work if the GTK_MODULES env var isn't set.
GtkModules loading with XSettings doesn't work if the GTK_MODULES env var isn...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-09-13 18:40 UTC by Cosimo Cecchi
Modified: 2008-09-13 19:01 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
patch (1.13 KB, patch)
2008-09-13 18:44 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2008-09-13 18:40:46 UTC 
GtkModules specified with XSettings doesn't work if the GTK_MODULES env var isn't set. You can test this now that bug 539840 is fixed in gnome-settings-daemon trunk.
Patch coming.
Comment 1 Cosimo Cecchi 2008-09-13 18:44:04 UTC 
Created attachment 118674 [details] [review]
patch

The loading of GtkModules specified in the xsetting is done by connecting to the "display-opened" signal of GdkDisplayManager, and then querying the setting.
That signal is connected by _gtk_modules_init (), that without my patch is called by gtkmain.c only if g_getenv (GTK_MODULES) != NULL.
Comment 2 Cosimo Cecchi 2008-09-13 18:46:01 UTC 
It would be important for this issue to be fixed before GNOME 2.24: as a consequence of the new gnome-session not setting gnomebreakpad in GTK_MODULES anymore, not having this would mean having no bug-buddy for crashers in 2.24.
Comment 3 Matthias Clasen 2008-09-13 18:53:42 UTC 
Nice catch, please commit.
Comment 4 Cosimo Cecchi 2008-09-13 19:01:29 UTC 
Committed to trunk, closing.

2008-09-13  Cosimo Cecchi  <cosimoc@gnome.org>

	Bug 552153 – GtkModules loading with XSettings doesn't work if the
	GTK_MODULES env var isn't set.

	* gtk/gtkmain.c: (do_post_parse_initialization):
	* gtk/gtkmodules.c: (_gtk_modules_init):
	Call _gtk_modules_init () even if gtk_modules_string is NULL, so
	that GtkModules specified with XSettings could be loaded.