After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 551761 - To much is logged
To much is logged
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
2.23.x
Other All
: Normal minor
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-11 07:09 UTC by Björn Torkelsson
Modified: 2008-09-22 12:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
patch to turn off debugging (1.66 KB, patch)
2008-09-11 20:06 UTC, Dan Winship 		rejected Details | Review

Description Björn Torkelsson 2008-09-11 07:09:13 UTC 
Please describe the problem:
Even for being a development version I think gnome-session logs to much. Logging to both syslog and to .xsession-errors, with the latter ignoring stuff after a while makes it harder to find problems with other components, is a bit to much in my opinion.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Dan Winship 2008-09-11 20:06:31 UTC 
Created attachment 118540 [details] [review]
patch to turn off debugging

Indeed. This turns the "debug" flag off by default (though you can re-enable it with --debug), and installs a g_log handler to eat the output of all of the g_debug()s scattered throughout the code when debugging is off.

(One of those things that I'd always meant to do, except that while I was still hacking on it, it had never reached the point where you'd actually want to turn off debugging :)
Comment 2 William Jon McCann 2008-09-11 20:09:35 UTC 
That's exactly what the following is for:
 gdm_log_set_debug (debug);


We just had it turned on by default while we were developing.  There's even this:
/* FIXME: turn this off closer to release */

:)
Comment 3 Dan Winship 2008-09-11 20:46:17 UTC 
oh. i saw the call to gdm_log_set_debug, I just assumed that it only controlled logging related to the interaction between gnome-session and gdm
Comment 4 Vincent Untz 2008-09-22 12:43:40 UTC 
I turn off debugging by default.