After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 551535 - Lockdown settings not saved to profile
Lockdown settings not saved to profile
Status: RESOLVED FIXED
Product: sabayon
Classification: Deprecated
Component: general
SVN trunk
Other Linux
: Normal major
: ---
Assigned To: Maintainers of sabayon
Maintainers of sabayon
Depends on: 322694
Blocks:
 
 
Reported: 2008-09-09 16:29 UTC by Tomas Bzatek
Modified: 2009-08-17 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sabayon-lockdown-save.patch (2.09 KB, patch)
2008-09-09 16:31 UTC, Tomas Bzatek
needs-work Details | Review
sabayon-lockdown-save.patch (2.06 KB, patch)
2008-09-11 16:09 UTC, Tomas Bzatek
needs-work Details | Review
sabayon-lockdown-save.patch (2.58 KB, patch)
2009-08-11 14:36 UTC, Tomas Bzatek
needs-work Details | Review

Description Tomas Bzatek 2008-09-09 16:29:11 UTC
Problem: Lockdown settings and possibly any other settings stored in GConf are not saved to profile.

Repro steps:
 1. create a new profile in Sabayon and open it for editing
 2. disable some functionality in Lockdown editor
 3. save the profile and close the nested session
 4. open/edit the profile again and see that the Lockdown settings are reset back to default

The reason the settings is not saved is that .gconf and .gconf.xml.defaults directories are listed under ignored directories (originally designed to ignore some paths during monitoring) and excluded when saving to zip storage.
Comment 1 Tomas Bzatek 2008-09-09 16:31:37 UTC
Created attachment 118366 [details] [review]
sabayon-lockdown-save.patch

Proposed dirty patch, using slightly different list of ignored directories for profile saving.
Comment 2 Tomas Bzatek 2008-09-11 16:09:34 UTC
Created attachment 118524 [details] [review]
sabayon-lockdown-save.patch

Updated patch which removes ~/.nautilus/metafiles directory from the ignore list to allow save desktop icons position etc.
Comment 3 Markus Kanet 2008-10-27 21:40:01 UTC
I can confirm this bug and the suggested patch works fine for me on Slackware 12.1 and GNOME 2.24.1/Sabayon 2.22.1

Markus
Comment 4 Tomas Bzatek 2009-03-23 14:57:42 UTC
To be 100% correct, we should make sure to fix bug 322694 first. Or add ".nautilus/metafiles" back to this patch.
Comment 5 Sayamindu Dasgupta 2009-04-19 18:10:49 UTC
This one works perfectly for me. Maybe you should also add .local/share/tracker to DIRECTORIES_TO_IGNORE_PROFILE ??
Comment 6 Siddhesh Poyarekar 2009-06-09 11:42:15 UTC
I guess .gconf.xml.mandatory needs to be removed from the list as well since mandatory settings do not get saved otherwise. To reproduce:

1) In the profiles window, Right Click on the top panel and click on Properties
2) In the Panel Properties, enable and disable the "Autohide" check box
3) In the sabayon "Changes" window, click on the lock against the latest entry (Panel Autohide key to false) to lock it
4) Save the profile and close the X nested window
5) Click on Details
6) Double click on Mandatory GConf settings

Mandatory GConf settings should have the Autohide=false setting, but is empty.
Comment 7 Tomas Bzatek 2009-08-11 14:36:26 UTC
Created attachment 140444 [details] [review]
sabayon-lockdown-save.patch

(In reply to comment #5)
> This one works perfectly for me. Maybe you should also add .local/share/tracker
> to DIRECTORIES_TO_IGNORE_PROFILE ??
Added, plus some others (.ccache, .dbus)

(In reply to comment #6)
> I guess .gconf.xml.mandatory needs to be removed from the list as well since
> mandatory settings do not get saved otherwise. To reproduce:
You're right, ".gconf.xml.mandatory" should be excluded as well. Does anybody know what's ".gconf.xml.mandatory-alt" used for?

I've also left ".nautilus/metafiles" excluded in despite of danger about wrong paths of some icons, but for generic ones (Computer, Trash, + application launchers) it should be fine.

I haven't had chance to test this patch on my machine, 2.27.0 keeps crashing on me, but changes are minimal.
Comment 8 Federico Mena Quintero 2009-08-17 21:28:37 UTC
Tomas, thanks so much for figuring this out.  I've committed your patch as commit 70106cf0.