After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 551212 - build failure: length undeclared
build failure: length undeclared
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: gio
Git master
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
: 551213 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-09-07 11:30 UTC by Frederic Peters
Modified: 2008-09-07 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixed spelling of length variable name (1.37 KB, patch)
2008-09-07 11:33 UTC, Frederic Peters
committed Details | Review

Description Frederic Peters 2008-09-07 11:30:10 UTC
Build got broken after http://svn.gnome.org/viewvc/pygobject?view=revision&revision=965

gfile.override: In function '_wrap_g_file_load_contents':
gfile.override:199: error: 'length' undeclared (first use in this function)
gfile.override:199: error: (Each undeclared identifier is reported only once
gfile.override:199: error: for each function it appears in.)
gfile.override: In function '_wrap_g_file_load_contents_finish':
gfile.override:273: error: 'length' undeclared (first use in this function)

This is because length was not spelled correctly before (lenght):

-        return Py_BuildValue("(sks)", contents, lenght, etag_out);
+        return Py_BuildValue("(s#ks)", contents, length, length, etag_out);
Comment 1 Frederic Peters 2008-09-07 11:33:54 UTC
Created attachment 118211 [details] [review]
Fixed spelling of length variable name
Comment 2 Paul Pogonyshev 2008-09-07 14:46:31 UTC
Committed.

Jonathan: please test that after your changes product at least keeps compiling fine.
Comment 3 Paul Pogonyshev 2008-09-07 14:47:31 UTC
*** Bug 551213 has been marked as a duplicate of this bug. ***
Comment 4 Jonathan Matthew 2008-09-07 22:28:37 UTC
My apologies.  I'd fully corrected the spelling in my working copy, but then I only committed the Py_BuildValue lines.  Without building the result.  I suck.