After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 551064 - Import of some files bought in the iTunes store fails
Import of some files bought in the iTunes store fails
Product: banshee
Classification: Other
Component: Metadata
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Reported: 2008-09-06 00:35 UTC by Yves
Modified: 2008-11-19 15:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch that fixes mediatype detection for some .m4a files. (765 bytes, patch)
2008-09-06 00:38 UTC, Yves
none Details | Review

Description Yves 2008-09-06 00:35:19 UTC
Banshee fails to import some .m4a files bought in the iTunes store, because taglib# is unable to detect the mediatype ("File does not contain audio or video").

I tracked the problem down to the usage of hdlr boxes by Apple: Some of the files I bought in the iTunes Store contain a second hdlr box as child of a minf box. The type of this box is 'alis', which is not recognized as a valid type by taglib. Because taglib decides on the mediatype based on the handler of the childs of the stsd box, which is defined after the 2nd/invalid occurence of the hdlr, the media type is not detected properly. This seems to be Apples fault, as ISO 14496-12 states that hdlr boxes are only valid in mdia or meta boxes, but not in minf boxes. Further, valid types are 'vide', 'soun' or 'hint' only. Maybe one should think about modifying the way the media type is detected (I don't know if/how this is explained in the standard, but other parser like AtomicParsley have no problem processing such files).

As a workaround, I created a patch that prevents the propagation of the handler if there is already a handler set and the new definition is neither of type video or audio. This allows Banshee to import the affected files again.
Comment 1 Yves 2008-09-06 00:38:02 UTC
Created attachment 118136 [details] [review]
Patch that fixes mediatype detection for some .m4a files.
Comment 2 Yves 2008-11-19 15:00:59 UTC
A fix is included in taglib-sharp