GNOME Bugzilla – Bug 550927
In 2.23.91, the bashism is added in mkiconlinks.sh.
Last modified: 2018-08-17 19:43:14 UTC
Please describe the problem: Error: -------------------------------- /bin/sh ../../../../common/mkiconlinks.sh ./symlinks.dat /var/tmp/gnome-themes/share/icons/HighContrastLargePrint/48x48/apps ../../../../common/mkiconlinks.sh: ${NEXTLINE:0...}: Bad substitution gmake[4]: *** [install] Error 2 -------------------------------- It was because of this line was added in 2.23.91 that is for bash, while it has #!/bin/sh in the top. -------------------------------- # Skip lines beginning with '#' if [ ! ${NEXTLINE:0:1} == "#" ]; then -------------------------------- Also, *BSD don't have bash in the base system. Suggest to replace it to here: -------------------------------- # Skip lines beginning with '#' if ! echo ${NEXTLINE} | grep -q "^#" ; then -------------------------------- It seems work fine to install gnome-themes 2.23.91 with this change. Steps to reproduce: 1. make install then get installation failure. Actual results: Expected results: Does this happen every time? yes Other information:
Created attachment 118061 [details] [review] Suggest a line replacement..
can we get a review here ?
*** Bug 552052 has been marked as a duplicate of this bug. ***
*** Bug 584581 has been marked as a duplicate of this bug. ***
(although personally I feel that my patch in bug 584581 is superior because cut is a smaller binary than grep :-)
(In reply to comment #5) > (although personally I feel that my patch in bug 584581 is superior because cut > is a smaller binary than grep :-) > This is pretty very moot. Why don't you grep the 'grep' word in configure and you will see that the configure requires grep. ;-) But which is better method (cut vs grep) other than pointless size, I don't know.
> This is pretty very moot. Why don't you grep the 'grep' word in configure and > you will see that the configure requires grep. ;-) > > But which is better method (cut vs grep) other than pointless size, I don't > know. I agree, the relative size of the binaries shouldn't be too big a concern. In my opinion, the use of grep provides a more instant recognition of what the line does (which is more important, IMO). I can't comment specifically for gnome-themes, but in general patches should be generated using `git format-patch --stdout -1 COMMIT-ID > my-patch.diff` from your own personal git tree, so they can be easily pushed upstream.
I would move this to "CONFIRMED" state and also bump to 2.32 as it's still valid Thanks
gnome-themes is not under active development anymore since 2011. As written in https://gitlab.gnome.org/Archive/gnome-themes/commit/4df81cf0a7fd8d3da6591c4c142f47dfd7778d5f , it is obsolete. Its codebase has been archived: https://gitlab.gnome.org/Archive/gnome-themes/commits/master Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.