After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550820 - Equalizer Suport
Equalizer Suport
Status: RESOLVED DUPLICATE of bug 76522
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other All
: Normal minor
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-04 11:15 UTC by Wilson Pinto Júnior
Modified: 2008-12-17 11:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Equalizer plugin patch (94.87 KB, patch)
2008-09-04 15:08 UTC, Wilson Pinto Júnior 		none Details | Review
equalizer.png (668 bytes, image/png)
2008-09-04 22:48 UTC, Wilson Pinto Júnior 		  Details
Equalizer patch for Rhythmbox (A.S. version) (6.19 KB, patch)
2008-11-13 07:02 UTC, Artur Szymiec 		rejected Details | Review

Description Wilson Pinto Júnior 2008-09-04 11:15:41 UTC 
I am Wrote a Equalizer plugin for rhythmbox.
Screenshot: http://n3rd3x.guake-terminal.org/ftp/equalizer_plugin.png
Patch: http://n3rd3x.guake-terminal.org/ftp/equalizer_plugin.patch.gz

Other information:
Comment 1 Bastien Nocera 2008-09-04 12:58:38 UTC 
Please attach the patch here so we can review the code in bugzilla directly.
Comment 2 Wilson Pinto Júnior 2008-09-04 15:08:11 UTC 
Created attachment 118015 [details] [review]
Equalizer plugin patch

The equalizer plugin patch!
Comment 3 Jonathan Matthew 2008-09-04 22:34:03 UTC 
How is this different to the equalizer patch on bug 76522?
Comment 4 Wilson Pinto Júnior 2008-09-04 22:48:49 UTC 
Created attachment 118063 [details]
equalizer.png

Please add the file in plugins/equalizer
Comment 5 Wilson Pinto Júnior 2008-09-04 22:49:55 UTC 
Yes, this patch is totally different to the another patch
Comment 6 Jonathan Matthew 2008-09-05 00:46:37 UTC 
Thanks for attaching the patch.

I was after a little more information than that, though.  How and why is it different?
Comment 7 Wilson Pinto Júnior 2008-09-12 11:00:26 UTC 
This plugin use "equalizer-10bands" gstreamer element, and have system global presets and user local presets!
Comment 8 Stefan Sauer (gstreamer, gtkdoc dev) 2008-11-11 10:11:09 UTC 
Could this use the preset support in gstreamer? See bug #522183. This can be committed immediately, it just needs some good presets.
Comment 9 Artur Szymiec 2008-11-13 07:01:04 UTC 
Greetings,

not being aware that somebody prepare patch from equalizer - I've mad an equalizer by myself. Here is attached patch. However it doesn't have a preset support yet.It works for both x-fade and non x-fade back ends.
Comments and testing are welcome.

Regards

Artur Szymiec
Comment 10 Artur Szymiec 2008-11-13 07:02:22 UTC 
Created attachment 122546 [details] [review]
Equalizer patch for Rhythmbox (A.S. version)
Comment 11 Jonathan Matthew 2008-11-13 23:46:50 UTC 
If you're going to upload a patch, please upload the actual patch file rather than a .tar.bz2 containing the patch.

There are several things I don't like about this patch (besides its wrapping):
- no presets
- rb_shell_preferences_equalizer_band_[0-9]_changed is ugly
- it adds things directly into the playback pipelines rather than using the filter interface that was added for that purpose
- it probably should be a plugin

I think it probably got the UI aspects right (except for the lack of presets) though.
Comment 12 Stefan Sauer (gstreamer, gtkdoc dev) 2008-11-14 14:01:07 UTC 
The GStreamer equalizer now has presets. Please use the gst preset mechanism. Then presets can be shared, users can send presets to gst community and we merge those in as updates.
Comment 13 Jonathan Matthew 2008-12-17 11:29:27 UTC 
I don't see any particular advantages of this equalizer plugin over the other one, so I'm going to arbitrarily close this bug.

*** This bug has been marked as a duplicate of 76522 ***