After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550622 - Signed e-mail with attachment are shown without attachment in the message list
Signed e-mail with attachment are shown without attachment in the message list
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-09-03 07:51 UTC by Jonathan Ernst
Modified: 2009-12-22 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot showing the issue (142.44 KB, image/png)
2008-09-03 07:56 UTC, Jonathan Ernst
  Details
eds patch (1.13 KB, patch)
2009-12-22 17:49 UTC, Milan Crha
committed Details | Review

Description Jonathan Ernst 2008-09-03 07:51:25 UTC
The paperclip is correctly shown in local folders but not in IMAP folders.
Comment 1 Jonathan Ernst 2008-09-03 07:56:20 UTC
Created attachment 117907 [details]
Screenshot showing the issue

Steps to reproduce :
1) Send or receive GPG signed e-mail to/in an IMAP e-mail account with an attachement
2) Read the mail and see that it has an attachment

Expected result :
a paper clip is shown in the message list to indicate that the mail has an attachment and to allow message sorting

Actual result :
no paper clip is shown in the message list although it is shown if the message is not signed
Comment 2 Jeffrey Stedfast 2008-09-03 12:24:32 UTC
we can't know that it has an attachment unless we download the entire message during folder summarization, and that is far too expensive for IMAP.

For local folders, that's what we do - but that's because we already have the message parsed, so it costs no additional time to check the child content-type.

Detecting whether a message has an attachment or not can never be 100% reliable - it's just a "guess" based on the toplevel Content-Type header.
Comment 3 Jonathan Ernst 2008-09-03 14:01:28 UTC
I don't see how it is different from another html or plain text message, the content-type is 
multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-atD7pUJvaDnXN19b+rH4"

instead of 

Content-Type: multipart/mixed; boundary="=-KE9KNhTvS1VCVQWlAdjP"

in both case you have to read the content type of the part in the designed boundary.

We are doing it for html text and plain text messages already. The content type in the signed message is visible in signed message : 

Content-Type: application/vnd.ms-excel; name="attachment.xls"

Even if you can tell me the difference between those two cases, the paperclip could be shown in sent (as Evolution knows that there is an attachment) and in received mails after the mail has been read (and parsed).

Comment 4 Milan Crha 2009-12-22 14:40:30 UTC
There had been done some changes in this part, namely bug #478239 and recently
in bug #604305. But even after them I see the above described behaviour, no attachment icon for signed messages in IMAP folder. Thus confirming.
Comment 5 Milan Crha 2009-12-22 17:49:56 UTC
Created attachment 150245 [details] [review]
eds patch

for evolution-data-server;

OK, got it, the previous implementation only tried to unset the attachment flag, but because the signed message hadn't this set, it even didn't try to see whether downloaded message has any attachment. There still applies that the message which is not downloaded yet is without the attachment icon, and when it is downloaded then the icon is shown (after the message list repaints).
Comment 6 Milan Crha 2009-12-22 17:51:46 UTC
Created commit f9a83a2 in eds master (2.29.5+)