After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550590 - Fetch covers from discogs
Fetch covers from discogs
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on: 550588
Blocks:
 
 
Reported: 2008-09-03 01:13 UTC by Bastien Nocera
Modified: 2018-05-24 13:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add discogs search to artsearch plugin. (5.71 KB, patch)
2012-08-12 08:59 UTC, radus
none Details | Review

Description Bastien Nocera 2008-09-03 01:13:35 UTC
Given a discog release, the artdisplay plugin should be able to fetch images from discogs directly.

See http://www.discogs.com/help/api
Comment 1 Adrian Zgorzałek 2012-02-11 16:10:41 UTC
I think I can write it, but after some investigations it looks like queries can return results with more than one matching entry.
For example here is the query which is affected:
http://api.discogs.com/database/search?q=LinkinParkMeteora&title

If guessing is good enough then let me know and I will start writing it.
Comment 2 Andy Buckley 2012-05-17 20:29:38 UTC
Hi Adrian,

I'm interested in having this feature, too. I had a look through the Discogs API docs, and it looks like you can restrict the results to the single master release by adding a type=master key into the URI:

http://api.discogs.com/database/search?type=master&q=LinkinParkMeteora

although it's probably better to use the more structured search, where it seems that using - signs in place of spaces is the standard thing to do:

http://api.discogs.com/database/search?type=master&artist=Linkin-Park&release_title=Meteora

Both these return a single result. The resource_url entry in the response then links to the main info for that master release:

http://api.discogs.com/masters/74533

and the first image URI in that is

http://api.discogs.com/image/R-2035596-1259935047.jpeg

I think this works generally. Hope that helps.

Andy
Comment 3 radus 2012-08-12 08:59:33 UTC
Created attachment 220932 [details] [review]
Add discogs search to artsearch plugin.

I haven't created patches using git before, I hope I did this right - let me know if it doesn't work.
Comment 4 Jonathan Matthew 2012-08-12 09:08:46 UTC
Last time we tried using discogs for cover art searches (in 2009/10), they blocked it fairly quickly. Without some agreement that this is OK from the Discogs staff, I don't think it's a good idea to add this.
Comment 5 radus 2012-08-12 16:28:28 UTC
This is what I read in their documentation: image requests are limited to 1000 request/24 hour period per ip address. Also, requests are throttled to one request per second per ip address. I don't see any other documented limitations.

Anyway, I can turn this into a separate plugin, similar to the AlbumArtSearch one. And the user can then save the image to their computer, if they want.
Comment 6 radus 2012-08-12 16:30:46 UTC
This is where I found the rules for accessing the API, I forgot to put it in the previous comment: http://www.discogs.com/developers/accessing.html
Comment 7 Jonathan Matthew 2012-08-12 22:24:07 UTC
Those rules haven't changed since last time. The issue wasn't the number of requests per client, it was the number of clients.
Comment 8 GNOME Infrastructure Team 2018-05-24 13:35:14 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/614.