After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550225 - Deleting already played files breaks playlist
Deleting already played files breaks playlist
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 554219 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-09-01 14:04 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2008-09-29 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Uhm? (56.76 KB, image/png)
2008-09-01 14:05 UTC, Diego Escalante Urrelo (not reading bugmail)
Details

Description Diego Escalante Urrelo (not reading bugmail) 2008-09-01 14:04:34 UTC
See the attached screenshot, you can reproduce by:

1. Add N files to the sidebar
2. Play the first 2 or 3
3. Delete the already played files
4. Breakage!

I can reproduce 90% of the time, let me know if you can't easily so I can try to get more specific conditions.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2008-09-01 14:05:18 UTC
Created attachment 117766 [details]
Uhm?
Comment 2 Bastien Nocera 2008-09-01 14:14:25 UTC
Please test with 2.23.91.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2008-09-27 21:52:47 UTC
Retested with 2.24.0 in Ubuntu.

Steps:
- Add 4 files
- Play first 2 (just skip after the first seconds)
- While the third one is playing, delete the first one
- 3rd and 4th file have a playing icon.

Comment 4 Bastien Nocera 2008-09-29 09:49:05 UTC
*** Bug 554219 has been marked as a duplicate of this bug. ***
Comment 5 Bastien Nocera 2008-09-29 11:02:35 UTC
Disabled in gnome-2-24. Needs fixing for trunk.

2008-09-29  Bastien Nocera  <hadess@hadess.net>

        * src/totem-playlist.c (totem_playlist_add_one_mrl):
        Disable the code to remove deleted files from the playlist,
        it screws up the ->current pointer (Helps: #550225)
Comment 6 Bastien Nocera 2008-09-29 13:33:24 UTC
Should be fixed in trunk. Please test, and reopen the bug if you can still see any problems.

2008-09-29  Bastien Nocera  <hadess@hadess.net>

        * src/totem-playlist.c (totem_playlist_set_reorderable),
        (totem_playlist_foreach_selected), (playlist_remove_files),
        (totem_playlist_move_files), (totem_playlist_file_changed),
        (totem_playlist_clear_with_compare): Clean up, and use only
        one codepath to remove files, whether selected files, or
        files matching a certain criteria.
        Should fix playlist weirdness when removing deleted files 
        from the playlist (Closes: #550225)