After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549949 - The Now Playing source in fullscreen mode causes crashes
The Now Playing source in fullscreen mode causes crashes
Status: RESOLVED INVALID
Product: banshee
Classification: Other
Component: Other Extensions
git master
Other Linux
: Normal major
: 1.x
Assigned To: Aaron Bockover
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-30 15:16 UTC by Bertrand Lorentz
Modified: 2008-10-10 20:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not destroy the fullscreen controls when hidden (1.97 KB, patch)
2008-08-30 15:19 UTC, Bertrand Lorentz
rejected Details | Review
Log of the crash (28.81 KB, text/plain)
2008-09-09 18:25 UTC, Bertrand Lorentz
  Details

Description Bertrand Lorentz 2008-08-30 15:16:12 UTC
Steps to reproduce :
1. Click on "Now Playing"
2. Go to fullscreen
3. Move the mouse so that the controls appear at the bottom
4. Leave fullscreen mode
5. Go to fullscreen
Banshee crashes

Another way to trigger the crash :
1. Click on "Now Playing"
2. Go to fullscreen
3. Move the mouse so that the controls appear at the bottom
4. Leave fullscreen mode
5. Change the volume

These crashes happen because the fullscreen controls are destroyed when they are hidden.

I'll attach a patch.
Comment 1 Bertrand Lorentz 2008-08-30 15:19:43 UTC
Created attachment 117643 [details] [review]
Do not destroy the fullscreen controls when hidden

This patch removes the DestroyControls() call from the OnHidden method. I'm not sure if it's appropriate to put it in the OnUnrealized method.

The patch also the volume button is disconnected from its events when the fullscreen controls are destroyed.
Comment 2 Gabriel Burt 2008-09-09 00:26:46 UTC
Hrm, I can't reproduce either (though I don't doubt you that it crashed of course).  Are you using compiz?  What was the actual stacktrace?
Comment 3 Bertrand Lorentz 2008-09-09 18:25:16 UTC
Created attachment 118374 [details]
Log of the crash

Here's the full log of the crash.

I'm using metacity, and mono 1.9.1.

I think the key to trigger the crash is to make the fullscreen controls appear the first time you switch to fullscreen.
Comment 4 Bertrand Lorentz 2008-09-09 18:26:20 UTC
Bah, bugzilla doesn't ask you if you want to re-open if you only add an attachment.
Comment 5 Bertrand Lorentz 2008-09-09 20:18:45 UTC
On second thoughts, it might be a GTK# issue, as the crash is actually happening in its code.
I'm using version 2.10.0.
Comment 6 Bertrand Lorentz 2008-10-10 20:16:24 UTC
After upgrading to GTK# 2.12.1, I can't reproduce this bug anymore.