After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549592 - [tnef attachment decoder] move from experimental to standard?
[tnef attachment decoder] move from experimental to standard?
Status: RESOLVED OBSOLETE
Product: evolution
Classification: Applications
Component: Plugins
2.26.x (obsolete)
Other Linux
: Normal major
: ---
Assigned To: evolution-plugin-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-08-27 15:12 UTC by Ruchir Brahmbhatt
Modified: 2021-05-19 11:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Email having attachment not being detected in evolution. (96.99 KB, text/plain)
2008-08-27 15:13 UTC, Ruchir Brahmbhatt
Details

Description Ruchir Brahmbhatt 2008-08-27 15:12:46 UTC
OS: OpenSUSE 11.0
Gnome: 2.22
Evolution: 2.22.1.1
Account type: Gmail IMAP
Download mails enabled.

I just received one mail stating there's attachment. But I saw only one attachment winmail.dat. I requested sender to send attachment again then she said its already there. So I checked in web mail, there it was showing up pdf attachment. The original mail is attached with private information hidden.
Comment 1 Ruchir Brahmbhatt 2008-08-27 15:13:46 UTC
Created attachment 117462 [details]
Email having attachment not being detected in evolution.
Comment 2 Matthew Barnes 2008-08-27 15:33:40 UTC
winmail.dat indicates the attachment was sent from Microsoft Outlook in a proprietary format.  As such, special steps are necessary to decode the attachment.  Evolution includes a plugin for decoding such attachments, but the plugin is deemed experimental and generally not included or enabled by default in Linux distros.  Some distros ship an additional "experimental plugins" package for Evolution that would include it, but I'm not sure if OpenSUSE does.
Comment 3 Ruchir Brahmbhatt 2008-08-27 17:05:49 UTC
Shouldn't it be included in mainstream as it is basic requirement for interoperability. We don't know we'll receive mail from which mail client. If web mail can detect it, evolution should also detect it.(no offense, just curious)
Comment 4 Matthew Barnes 2008-08-27 17:56:19 UTC
I'm not sure why it was determined to be experimental.  Maybe it's time to revisit that.  Srini, any historical insight here?
Comment 5 Srinivasa Ragavan 2008-08-27 19:00:23 UTC
Matt, libytnef isn't a most popular lib yet to be included always. Atleast when it was written, we had to search for some rotten lib somewhere.
Comment 6 Matthew Barnes 2008-08-27 20:03:13 UTC
I see.  If the plugin itself is fairly stable, maybe we could tag it as such and build the plugin only if libytnef is detected at configure time.  Then distros could choose whether to make libytnef a build requirement.

But first I'd have to take a closer look at the plugin to judge whether it's fit to be considered stable.
Comment 7 Paul Bolle 2008-08-28 15:09:24 UTC
(In reply to comment #6)
> [...] maybe we could tag it as such
> and build the plugin only if libytnef is detected at configure time.

From configure.in:
[...]
AC_MSG_CHECKING([for yTNEF])
AC_TRY_COMPILE([#include <stdio.h> 
                #include <ytnef.h>],
        [TNEFStruct *tnef;], tnef_ok=yes, tnef_ok=no)
if test "$tnef_ok" = "yes"; then 
        AC_MSG_RESULT([yes])
        TNEF_ATTACHMENTS="tnef-attachments"
        TNEF_CFLAGS="-DHAVE_YTNEF_H"
else
        AC_TRY_COMPILE([#include <stdio.h> 
                        #include <libytnef/ytnef.h>],
                [TNEFStruct *tnef;], tnef_ok=yes, tnef_ok=no)
        if test "$tnef_ok" = "yes"; then 
                AC_MSG_RESULT([yes])
                TNEF_ATTACHMENTS="tnef-attachments"
                TNEF_CFLAGS="-DHAVE_LIBYTNEF_YTNEF_H"
        else
                AC_MSG_RESULT(no)
                TNEF_ATTACHMENTS=""
                TNEF_CFLAGS=""
        fi
fi
AC_SUBST(TNEF_CFLAGS)

echo "TNEF is "$TNEF_ATTACHMENTS
[...]

It's been a few months that I fixed an (Fedora specific) issue with this fragment, but isn't that what the current setup does? If I remember correctly the current configure/make system will simply skip the TNEF decoder plugin silently if libytnef isn't detected with this test.
Comment 8 Matthew Barnes 2008-08-28 16:25:39 UTC
Ah, you're correct.  So I guess we just need to review whether the plugin is suitable for tagging as "stable".  I myself have no insight here.  Srini?

We should also add a line item to the configuration summary indicating whether libytnef support (or better, "Outlook Attachment Support") is enabled.
Comment 9 Paul Bolle 2008-08-28 17:03:19 UTC
(In reply to comment #8)
> So I guess we just need to review whether the plugin is
> suitable for tagging as "stable".  I myself have no insight here.

0) My limited testcase (about two dozen winmail.dat attachments) was parsed without problems (no crashes or similar surpises).

1) The code does warrant some cleanup. I'm available to discuss the details (but b.g.o. doesn't feel like the right channel to do that).

2) Furthermore, it should be possible to treat winmail.dat attachments transparently in the future (i.e. just parse them and present their content as ordinary MIME parts). There are some problems (such as: how should we treat message text send as an RTF?) but nothing too intimidating.

3) At the moment I can not do 2) or 3). I do hope to be able to do it shortly.
Comment 10 Matthew Barnes 2008-08-28 17:30:04 UTC
(In reply to comment #9)
> 3) At the moment I can not do 2) or 3). I do hope to be able to do it shortly.

Your recursion is making my brain hurt.  :-P

Comment 11 Ruchir Brahmbhatt 2008-09-28 09:45:21 UTC
Is it expected to make it in 2.26?
Comment 12 Srinivasa Ragavan 2008-09-29 05:49:57 UTC
It would be enabled, if libytnef is available in your distro. I dont think I would request for ext-dep for GNOME for this library.
Comment 13 Ruchir Brahmbhatt 2008-09-29 06:03:05 UTC
If I have built evolution from source, do I need to rebuild it after installing that library?
Comment 14 Paul Bolle 2009-01-29 13:04:27 UTC
(In reply to comment #13)
> If I have built evolution from source, do I need to rebuild it after installing
> that library?

Yes, if you want to be able to decode TNEF attachments in evolution you have to install libytnef (and possibly something like libytnef-devel, or whatever that is called in OpenSUSE) and then rebuild evolution (and make sure experimental plugins are build too).

Comment 15 Paul Bolle 2009-01-29 21:42:24 UTC
Housekeeping: the topic of this bug seems to have become: should the TNEF Attachment Decoder plugin be upgraded from "experimental" (to "standard")? Adjust several fields accordingly.
Comment 16 Ruchir Brahmbhatt 2009-01-30 07:16:06 UTC
I think it should be moved to standard.
Comment 17 Milan Crha 2009-10-27 17:18:51 UTC
Any decision so far? We are after 2.29.1 right now, so can be done finally?
Comment 18 Matthew Barnes 2009-10-28 12:51:50 UTC
The topic came up on our mailing list too.  If someone can verify the plugin actually works then I'll promote it to our standard set.  I don't have any winmail.dat files handy to test it for myself.
Comment 19 Ruchir Brahmbhatt 2009-10-28 12:58:36 UTC
(In reply to comment #18)
> The topic came up on our mailing list too.  If someone can verify the plugin
> actually works then I'll promote it to our standard set.  I don't have any
> winmail.dat files handy to test it for myself.

I have a mail with winmail.dat handy. I can help with testing. BTW I am using evolution from opensuse gnome factory repository. How do I test the plugin in this version?
Comment 20 Paul Bolle 2009-10-28 13:05:32 UTC
(In reply to comment #18)
> If someone can verify the plugin
> actually works then I'll promote it to our standard set. 

See my comment #9. It used to work (sufficiently) about a year ago.

There is another bug where I detailed the current problems with this plugin.
Enabling it will probably expose other problems and thus might trigger more
feedback, patches, etc. The goal in handling these attachments should be, in my
opinion, to parse them, use what is interesting and than entirely hide them
from view. (Which could be more trouble than these attachments are actually
worth.)

Feel free to prod for information me about those strange attachments.

> I don't have any
> winmail.dat files handy to test it for myself.

You might find some of these here in bugzilla or on public mailing list. (Do
note that quite a number of these are actually empty and apparently only used
by Microsoft Exchange for internal purposes. I don't know. I don't really
care.).
Comment 21 Matthew Barnes 2009-10-28 14:31:47 UTC
Either of you know of any open-source TNEF _encoders_ that we could use to generate our own winmail.dat files or testing?  Thought there might be something out there that works kind of like gzip.
Comment 22 Paul Bolle 2009-10-28 14:42:01 UTC
(In reply to comment #21)
> Either of you know of any open-source TNEF _encoders_ that we could use to
> generate our own winmail.dat files or testing?

No, sorry. (A quick search on the web, like you probably just did, turned up nothing too.)
Comment 23 Paul Bolle 2009-11-19 16:20:05 UTC
(In reply to comment #20)
> There is another bug where I detailed the current problems with this plugin.

Here I probably was thinking about bug #563579.
Comment 24 André Klapper 2021-05-19 11:56:05 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. 
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines
and create a new bug report ticket at
  https://gitlab.gnome.org/GNOME/evolution/-/issues/

Thank you for your understanding and your help.