After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548639 - crash when editing a profile with gconf-editor
crash when editing a profile with gconf-editor
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.23.x
Other Linux
: High critical
: ---
Assigned To: empathy-maint
empathy-maint
: 561247 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-08-20 12:26 UTC by Frederic Peters
Modified: 2009-03-29 08:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Frederic Peters 2008-08-20 12:26:48 UTC 
I was editing a mission control profile with gconf-editor when Empathy crashed (note it may be unrelated).

+ Trace 205423

  • #0 empathy_avatar_image_set
    at empathy-avatar-image.c line 268
  • #0 empathy_avatar_image_set
    at empathy-avatar-image.c line 268
  • #1 contact_widget_avatar_notify_cb
    at empathy-contact-widget.c line 802
  • #2 contact_widget_contact_update
    at empathy-contact-widget.c line 654
  • #3 contact_widget_set_contact
    at empathy-contact-widget.c line 323
  • #4 contact_widget_change_contact
    at empathy-contact-widget.c line 704
  • #5 contact_widget_id_activate_timeout
    at empathy-contact-widget.c line 332
  • #6 g_timeout_dispatch
    at /home/fred/checkout/gnome-2.24/debian/glib-2.17.7/glib/gmain.c line 3532
  • #7 IA__g_main_context_dispatch
    at /home/fred/checkout/gnome-2.24/debian/glib-2.17.7/glib/gmain.c line 2073
  • #8 g_main_context_iterate 






Comment 1


Xavier Claessens





          2009-03-20 12:01:43 UTC
        



Did you have a contact information window open? Or any window showing a contact widget? Add contact dialog maybe?

Or did you had such a window open, then closed it?

Profiles are not in gconf, what where you really doing in gconf-editor? Modify accounts?






Comment 2


Frederic Peters





          2009-03-20 12:19:54 UTC
        



I can't remember what I was doing (perhaps you should respond faster), and as I noted at that time it may not even be related to gconf editing.

empathy_avatar_image_set() has:

        EmpathyAvatarImagePriv *priv = GET_PRIV (avatar_image);
        GdkPixbuf              *scaled_pixbuf;        

        g_return_if_fail (EMPATHY_IS_AVATAR_IMAGE (avatar_image));

Obviously the GET_PRIV() should happen after the g_return_if_fail().

Looks like an easy fix.






Comment 3


Xavier Claessens





          2009-03-20 13:57:39 UTC
        



That fixes the effect, not the cause.






Comment 4


Frederic Peters





          2009-03-20 15:37:52 UTC
        



Still better than nothing; and perhaps you could look at the backtrace to find the cause.






Comment 6


Xavier Claessens





          2009-03-20 16:29:08 UTC
        



*** Bug 561247 has been marked as a duplicate of this bug. ***






Comment 7


Guillaume Desmottes





          2009-03-20 19:03:11 UTC
        



Here again, I'd prefer: "if (error != NULL)"

+1 otherwise






Comment 8


Xavier Claessens





          2009-03-29 08:27:40 UTC
        



merged, thanks.