After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548197 - no radio stations provided by default
no radio stations provided by default
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Internet Radio
git master
Other All
: Normal enhancement
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 622845 633243 642835 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-08-18 00:20 UTC by javiermon
Modified: 2011-08-21 04:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screamer radio presets (183.56 KB, application/gzip)
2011-02-20 21:19 UTC, DisembodiedVoice
  Details
Support default radio stations (2.02 KB, patch)
2011-06-24 13:24 UTC, Martin Pitt
committed Details | Review

Description javiermon 2008-08-18 00:20:24 UTC
Please describe the problem:
Hi

Banshee 0.1 used to provide a set of radio stations by default, but this is no longer the case. Now the radio plugin is empty. Can we have them back again?

thanks

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Michael Monreal 2008-08-18 11:23:52 UTC
It would even be handy to have the list of 0.13.x stations available on the Wiki for example, so that we can add them manually.
Comment 2 Andrew Conkling 2008-08-18 12:37:50 UTC
Good idea. I couldn't find a list of stations on the wiki, could you supply that? Additionally, this bug can collect a list of other stations also that could be added. If you submit some, please consider adding popular stations (e.g. "Top 10 Radio stations" from coolestpodcasts.org or something) rather than just what you'd like to see.
Comment 3 Ivan Zlatev 2008-10-28 14:48:11 UTC
(copy -> paste from the mailing list)

Currently Banshee ships with exactly zero predefined online radio
stations, which IMHO is bad. May be we could at least add the free
Di.FM and Sky.FM radio stations? Those include over 50 stations with a
large variety of genres. The full list of the stations is below [1].
What do you think?

What would be a good way to add a predefined list of stations? A xml
list embedded as a resource and imported into the DB on the first run
of the Radio extension?


[1] Station Listing

=== Sky.FM - http://www.sky.fm/ ===

All Hit 70s
Alternative Rock
Beatles Tribute
Best of the 80s
Bossa Nova Jazz
Classic Rap
Classic Rock
Classical Guitar
Contemporary Christian
Country
DaTempo Lounge
Indie Rock
Love Music
Modern Jazz
Mostly Classical
New Age
Oldies
Piano Jazz
Roots Reggae
Salsa
Simply Soundtracks
Smooth Jazz
Solo Piano
Top Hits Music
Uptempo Smooth Jazz
Urban Jamz
World Music

=== DI.FM - http://www.di.fm/ ===

Ambient
Breaks
Chillout
DJ Mixes
Drum 'n' Bass
Electro House
EuroDance
Funky House
Future Synthpop
Gabber
Goa-Psy Trance
Hard Core
Hard Dance
Hardstyle
House
Lounge
Minimal
Oldschool Electronica
Progressive
Soulful House
Techno
Trance
Tribal House
Vocal Trance
Comment 4 Eric Lúcio 2008-10-29 14:23:26 UTC
Its an basic feature in todays media players, hope that its included in next version of banshee.
Like the other person spoke, i think that TOP radios button (shows the radios with most people connected in it) its a great ideia!
Comment 5 Paul Lange 2009-10-08 10:08:01 UTC
I would like to work on that.

The question is if we want to hardcode some default stations as proposed in comment 3 or if we want to present a listing of stations, for example from the shoutcast directory.

Any thoughts?
Comment 6 Michael Martin-Smucker 2010-06-27 15:04:42 UTC
*** Bug 622845 has been marked as a duplicate of this bug. ***
Comment 7 Pavlo Verba 2010-06-27 15:22:46 UTC
I agree, this is a basic feature that should be included by default.
Comment 8 Michael Martin-Smucker 2010-10-27 12:13:07 UTC
*** Bug 633243 has been marked as a duplicate of this bug. ***
Comment 9 Michael Martin-Smucker 2011-02-20 21:11:23 UTC
*** Bug 642835 has been marked as a duplicate of this bug. ***
Comment 10 DisembodiedVoice 2011-02-20 21:19:13 UTC
Created attachment 181428 [details]
Screamer radio presets
Comment 11 DisembodiedVoice 2011-02-20 21:20:39 UTC
Repost as I failed to find this bug before:
Adding radio stations manually is a tedious, tiring task. There are several
collections of them available already, though, which could be packaged with
banshee, adding greatly to its user-friendliness. In particular,
http://www.screamer-radio.com/ has a database of stations that could be used.
I've attached the xml file of them to this report to see if it could easily be
added.
Comment 12 Martin Pitt 2011-06-17 15:30:48 UTC
I just stumbled over this myself, as I currently implement a project for easy distro customization.

I noticed that Banshee has some code to migrate ~/.config/banshee/plugins/stations/*.xspf, as part of a legacy configuration conversion.

*.xspf is being used by Rhythmbox as well for default radio stations.

As a prerequisite for being able to ship default radio stations with banshee, would you accept a patch which looks in PREFIX/share/banshee/stations/default.xspf, and imports these into the user profile on first start? This wouldn't be considered "legacy user configuration migration", but should be kept.
Comment 13 Martin Pitt 2011-06-17 15:33:35 UTC
... or even PREFIX/share/banshee/stations/*.xspf
Comment 14 Martin Pitt 2011-06-24 13:24:05 UTC
Created attachment 190582 [details] [review]
Support default radio stations

With this patch I can create /usr/share/banshee/stations/default.xsps, and they get imported nicely into the user's DB at first start.

WDYT?
Comment 15 Chow Loong Jin 2011-07-12 03:09:59 UTC
Here's a compiled list of radio stations supported by Rhythmbox.

https://ftbeowulf.wordpress.com/2011/05/03/unity-banshee-radio-stations/
Comment 16 Iain Lane 2011-08-05 13:15:26 UTC
Can someone please review this patch?
Comment 17 Bertrand Lorentz 2011-08-19 15:53:51 UTC
Review of attachment 190582 [details] [review]:

Thanks for the patch Martin !
And sorry it took so long to review it.

I like the idea, especially since it's up o admins and distros to figure which default stations to ship, so we don't have to do much ;)

I've committed the patch, with a few changes to better separate the loading of default stations from the legacy migration :
http://git.gnome.org/browse/banshee/commit/?id=8b73d84c

Keep in mind that the xspf files have to be in place before Banshee is ever started, as we'll only look once for those xspf, and never
again, even if there were no files found or errors while loading the files.
Comment 18 Bertrand Lorentz 2011-08-19 16:07:57 UTC
With the above change committed, I'm marking this as fixed.

We haven't provided default radio station ourselves for 3 years, and I don't think we'll ever do it. Ideally we should provide nice ways to find good radio stations.

So now, you might not always get default radio stations, but you can now direct your complaints to your distribution, or create your own packages to provide default stations ;)

Feel free to report any other bugs you might find, and suggest enhancements for the radio stations by creating separate bugs.
Comment 19 Chow Loong Jin 2011-08-21 04:45:20 UTC
https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/394812/+attachment/2296319/+files/default-stations.tar.xz

The above link is a tarball of the default radio stations included in pre-1.0 Banshee, compiled from http://ftbeowulf.wordpress.com/2011/05/03/unity-banshee-radio-stations/.

Do we want to have this included upstream?

Also, as I have noted in https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/394812/comments/9, I'd like to have put everything into one file, but due to the nature of the XspfMigrator taking the playlist title as the genre, I can only put stations of the same genre into one playlist.

The rhythmbox version has something like the following in each <track> element. Could we perhaps use something like that?
<extension application="http://www.rhythmbox.org">
    <genre>90's</genre>
</extension>